Skip to content

Conversation

ndhansen
Copy link
Contributor

Fixes #310

I didn't add tests because I couldn't see any existing tests for the call_api method, but if I missed it, please let me know.

(This is a copy of MR #311, but I needed to resolve a conflict and accidentally had been working on the master branch.)

Copy link
Owner

@tomplus tomplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.06%. Comparing base (abd4624) to head (e3bf336).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   27.06%   27.06%           
=======================================
  Files         805      805           
  Lines       98720    98722    +2     
=======================================
+ Hits        26717    26719    +2     
  Misses      72003    72003           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tomplus
Copy link
Owner

tomplus commented Jun 27, 2025

Thank you!

@tomplus tomplus merged commit bfdc475 into tomplus:master Jun 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

response_types_map not treated as an optional argument

2 participants