chore: requeue nodes for retry missing target size#59
Merged
dzmitryharchanin-tomtom merged 3 commits intomainfrom Jan 29, 2026
Merged
Conversation
SajadOrouji-TomTom
requested a review
from dzmitryharchanin-tomtom
as a code owner
SajadOrouji-TomTom
changed the title
dzmitryharchanin-tomtom
approved these changes
Jan 29, 2026
dzmitryharchanin-tomtom
deleted the
chore/requeueNodesForRetry-missing-targetSize
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request addresses an issue where the
TargetSizefield could be lost during the requeueing of node termination operations, which could lead to incorrect scaling behavior. The main changes ensure thatTargetSizeis preserved when nodes are requeued for retry, and a new test is added to verify this behavior.Bug fix: TargetSize preservation during node requeue
requeueNodesForRetrymethod intermination.goto accept and propagate theTargetSizeparameter, ensuring it is included in requeued messages.Testing improvements
TestTerminationService_TargetSizeLostDuringRequeueintermination_test.goto verify thatTargetSizeis correctly preserved and used during requeue and revert operations, preventing regressions.Changes Made
Why?
Related Issue(s)
Type of change
Please delete options that are not relevant.