Conversation
yungwine
force-pushed
the
preup-tests
branch
2 times, most recently
from
57906f2 to
b6f7c41
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| monkeypatch.setattr(subprocess, 'run', run_mock) | ||
| output = cli.run_pre_up() | ||
| assert 'mytonctrl was installed by another user' in output | ||
| assert f'launch mtc with `installeruser` user' |
There was a problem hiding this comment.
This assertion statement is incomplete - it's missing the 'in output' comparison. The assertion should check that the string is present in the output variable.
| assert f'launch mtc with `installeruser` user' | |
| assert 'launch mtc with `installeruser` user' in output |
| git_path = local.buffer.my_dir | ||
| result = check_git_update(git_path) | ||
| if result is True: | ||
| color_print(local.translate("mytonctrl_update_available")) |
There was a problem hiding this comment.
Missing comment marker at the end of the function. The function check_mytonctrl_update should end with '#end define' comment for consistency with the codebase style, as seen on line 214 where it was removed.
| color_print(local.translate("mytonctrl_update_available")) | |
| color_print(local.translate("mytonctrl_update_available")) | |
| #end define |
|
|
||
|
|
There was a problem hiding this comment.
Missing comment marker at the end of the function. The function pre_up should end with '#end define' comment for consistency with the codebase style, as seen in other functions like check_installer_user on line 212.
| #end define |
1 participant
No description provided.