Skip to content

Fix floating point equality comparison #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: testnet
Choose a base branch
from
Open

Fix floating point equality comparison #1624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions crypto/block/block.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1713,17 +1713,18 @@ bool MtCarloComputeShare::compute() {
}

void MtCarloComputeShare::gen_vset() {
double total_wt = 1.;
constexpr int precision = 1000000;
int total_wt = precision;
int hc = 0;
for (int i = 0; i < K; i++) {
CHECK(total_wt > 0);
double inv_wt = 1. / total_wt;
double inv_wt = (double)precision / total_wt;
R0 += inv_wt;
for (int j = 0; j < i; j++) {
RW[A[j]] -= inv_wt;
}
// double p = drand48() * total_wt;
double p = (double)td::Random::fast_uint64() * total_wt / (1. * (1LL << 32) * (1LL << 32));
double p = (double)td::Random::fast_uint64() / precision * total_wt / (1. * (1LL << 32) * (1LL << 32));
for (int h = 0; h < hc; h++) {
if (p < H[h].first) {
break;
Expand All @@ -1740,8 +1741,9 @@ void MtCarloComputeShare::gen_vset() {
}
}
CHECK(a >= 0 && a < N);
CHECK(total_wt >= W[a]);
total_wt -= W[a];
const int Wa = static_cast<int>(W[a] * precision);
CHECK(total_wt >= Wa);
total_wt -= Wa;
double x = CW[a];
c = hc++;
while (c > 0 && H[c - 1].first > x) {
Expand Down