fix(ui): don't preload 30+ pictures of wallets#472
Open
klpx wants to merge 1 commit intoton-connect:mainfrom
Open
fix(ui): don't preload 30+ pictures of wallets#472klpx wants to merge 1 commit intoton-connect:mainfrom
klpx wants to merge 1 commit intoton-connect:mainfrom
Conversation
|
@klpx is attempting to deploy a commit to the TOP Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This preload functionality generates a huge load on the CDN serving pictures.
The preload is unnecessary because the "Connect" button is not called all the time, and when it is called, only a few icons are shown.
Here is the Network tab where we can see all these pictures being loaded:
After this change, we can see that this is no longer the case:
The FCP might have actually improved, but it's not certain:
We can now see that when the Dialog is opened, pictures are loaded on-demand and displayed correctly:
