Skip to content

chore: migration to typescript privacy modifier style#309

Merged
krigga merged 1 commit intoton-org:developfrom
Danil42Russia:danil42russia/typescript_privacy_modifier
Sep 23, 2025
Merged

chore: migration to typescript privacy modifier style#309
krigga merged 1 commit intoton-org:developfrom
Danil42Russia:danil42russia/typescript_privacy_modifier

Conversation

@Danil42Russia
Copy link
Copy Markdown
Contributor

Issue

Closes #

Checklist

Please ensure the following items are completed before requesting review:

  • Updated CHANGELOG.md with relevant changes
  • Documented the contribution in README.md
  • Added tests to demonstrate correct behavior (both positive and negative cases)
  • All tests pass successfully (yarn test)
  • Code passes linting checks (yarn lint)

@krigga
Copy link
Copy Markdown
Contributor

krigga commented Sep 22, 2025

What is the purpose of this migration? I don't see a great reason for it other than syntactic preferences perhaps, perhaps I'm missing something?

Also naming is inconsistent now - some of the renamed vars just have the # removed, while others have _ prepended, like here https://github.com/ton-org/blueprint/pull/309/files#diff-6a0066a2fed979a47d4a9d58272e00ada2663c1175b99f36c8ca66b806d166d7L79 (but in other places too)

@i582
Copy link
Copy Markdown
Contributor

i582 commented Sep 22, 2025

@krigga, I think this is a good addition, as the code is much more readable, shorter, and, in fact, safer, since some fields are now readonly. Also, this project uses TypeScript, not JavaScript, so there's no need to use the horrible #foo syntax :)
Moreover, some code actually uses the private keywords, so this is good for consistency

@Danil42Russia Danil42Russia force-pushed the danil42russia/typescript_privacy_modifier branch from 0b39a18 to 41dc358 Compare September 22, 2025 17:30
@Danil42Russia
Copy link
Copy Markdown
Contributor Author

What is the purpose of this migration?

To ensure a consistent style throughout the project. Currently, some places use #, while others use private.

Also naming is inconsistent now - some of the renamed vars just have the # removed, while others have _ prepended

_ was added to fields whose names match the names of functions

@krigga krigga merged commit f88979b into ton-org:develop Sep 23, 2025
4 checks passed
@github-actions
Copy link
Copy Markdown

🎉 @Danil42Russia, your reward is ready! Claim it here

@Danil42Russia Danil42Russia deleted the danil42russia/typescript_privacy_modifier branch September 23, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants