Fix slice_compute_data_size? parameter type in stdlib.fc#336
Open
a08778 wants to merge 1 commit intoton-org:developfrom
Open
Fix slice_compute_data_size? parameter type in stdlib.fc#336a08778 wants to merge 1 commit intoton-org:developfrom
a08778 wants to merge 1 commit intoton-org:developfrom
Conversation
Corrects the function signature of slice_compute_data_size? in stdlib.fc. The function was incorrectly declared with a `cell` parameter, while the underlying SDATASIZEQ instruction operates on a `slice`. This change updates the parameter type to `slice` to match actual usage and prevent type errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the function signature of slice_compute_data_size? in stdlib.fc. The function was incorrectly declared with a
cellparameter, while the underlying SDATASIZEQ instruction operates on aslice. This change updates the parameter type tosliceto match actual usage and prevent type errors.Issue
Closes #
Checklist
Please ensure the following items are completed before requesting review:
CHANGELOG.mdwith relevant changesREADME.mdyarn test)yarn lint)