-
Notifications
You must be signed in to change notification settings - Fork 43
feat(Fift): Words, Constants and Variables page #1472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 7 commits
3777405
1464e68
b649d0d
9bc16f9
b42906f
8b5253d
f1ce11e
043ffca
269aa61
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,293 @@ | ||||||||||||||||||||||||||
| --- | ||||||||||||||||||||||||||
| title: "Words, Constants, and Variables" | ||||||||||||||||||||||||||
| sidebarTitle: "Words, Constants, and Variables" | ||||||||||||||||||||||||||
| noindex: "true" | ||||||||||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [MEDIUM] Frontmatter
|
||||||||||||||||||||||||||
| noindex: "true" | |
| noindex: true |
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phrase
identifier for an execution token, also known as a
WordDef
may be confusing after editing types.mdx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would show that variable x is the same as hole constant x and link to { hole constant } : variable in Fift.fif.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[HIGH] Banned filler word “simply” in body text
The comment explaining the getter x includes the phrase “simply write x” on these lines. The extended style guide explicitly bans filler and hedging terms like “simply” in instructional text and requires neutral, precise wording instead, so this phrasing violates a MUST-NOT rule and creates an inconsistent tone. Replacing “simply” with neutral language keeps the instruction clear while aligning with the documented style requirements, as outlined in https://github.com/ton-org/docs/blob/main/contribute/style-guide-extended.mdx?plain=1#L214-L220.
| // Define word x so that it reads the box contents. | |
| // Now, x can be treated as if | |
| // it was the "variable". | |
| // In other words, instead of writing "x-box @" | |
| // to read the variable contents, simply write "x". | |
| { x-box @ } : x | |
| // Define word x so that it reads the box contents. | |
| // Now, x can be treated as if | |
| // it was the "variable". | |
| // In other words, instead of writing "x-box @" | |
| // to read the variable contents, write "x". | |
| { x-box @ } : x |
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix the comment typo comming > coming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add link to /languages/fift/control#blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in issue #1556. Links cannot be solved in this PR because other PRs need to be merged into main first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[HIGH] Page title and sidebar title not in sentence case
The frontmatter
titleandsidebarTitlecurrently use title case ("Words, Constants, and Variables"), capitalizing common nouns instead of following sentence case. The documentation style guide requires headings and titles to capitalize only the first word and proper nouns, and marks violations of this rule as high severity (seehttps://github.com/ton-org/docs/blob/main/contribute/style-guide-extended.mdx?plain=1#L445-L452for the sentence case rule). Leaving these in title case creates inconsistency across navigation and search listings where these titles are displayed. Aligning them with sentence case improves coherence and adherence to the established documentation standards.Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!