test: add public e2e harness with S3/LocalStack and drop test-helpers gating#534
Open
test: add public e2e harness with S3/LocalStack and drop test-helpers gating#534
Conversation
ethe
requested changes
Dec 19, 2025
Member
ethe
left a comment
ethe
left a comment
There was a problem hiding this comment.
- Tests won't compile or run -
compaction_gc.rs,conflict.rs,scan_plan.rs,time_travel.rs,wal_policy.rs,wal_rotation.rs,wasm_compat.rsare dead code. workspace_temp_dir(),extract_rows(),wal_cfg_with_backend()copy-pasted across 7+ files#[path = "common.rs"]is anti-pattern, it does align with the best practice provided by rust official.- both
src/db/tests/backend.rsandsrc/tests_internal/backend.rshandle S3 setup
| let descriptor = SsTableDescriptor::new(SsTableId::new(pass as u64 + 1), 0); | ||
| if let Err(err) = flush_immutables(&db, Arc::clone(&sst_cfg), descriptor).await { | ||
| eprintln!("flush skipped: {err}"); | ||
| return Ok(()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/(read smoke, WAL durability/rotation, time-travel). They use onlyDbBuilder/DBAPIs; S3 runs remain opt-in viaTONBO_S3_*.src/db/tests/(compaction GC/loop, WAL policy/rotation, durability variants, scan plan, conflict, public API with S3/local harnesses, wasm-compat). These use crate-private helpers and cfg(test) knobs.src/db/tests/backend.rsandsrc/test_support.rsprovide WAL/FS/S3 harnesses and test helpers;tests/s3_localstack_env.shremains for LocalStack setup.cargo test --package tonbo --lib public_api:: -- --nocapture; pre-commit runs fmt/clippy/tests and conditionally starts LocalStack, falling back to local-only if Docker isn’t available.src/db/tests/integrationnamespace and collapsedtests/e2e/*intotests/*. Cargo.toml updated to point at the new test paths. No public API surface changes.