Added check for remote sound files (http)#58
Open
lgillstrom wants to merge 10 commits intotonistiigi:developfrom
Open
Added check for remote sound files (http)#58lgillstrom wants to merge 10 commits intotonistiigi:developfrom
lgillstrom wants to merge 10 commits intotonistiigi:developfrom
Conversation
Collaborator
|
I like the idea of having remote sources, but this probably isn't the best way of doing it. |
SargoDarya
requested changes
Jul 11, 2017
|
|
||
|
|
||
| opts.logger.debug('Start processing', { file: src}) | ||
| var remote = src.indexOf('http') == 0; |
Collaborator
There was a problem hiding this comment.
Better check here would be
/^https?:\/\//.test(src)
that's slightly more expensive but safer. Otherwise we might run into surprises.
| if (exists) { | ||
| let ffmpeg = spawn('ffmpeg', ['-i', path.resolve(src)] | ||
| if (exists || remote) { | ||
| let ffmpeg = spawn('ffmpeg', ['-i', remote?src:path.resolve(src)] |
Collaborator
There was a problem hiding this comment.
When using the ternary, use spaces. Otherwise it's hard to read.
Release 0.7.0 (develop => master)
use dash flag with webm
Remove the --with-libogg flag from the installation instructions for ffmpeg as the option does not exist anymore. Fixes tonistiigi#64
Conflicts: audiosprite.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added check to see if src file is an url instead of a local file. There is probably a more elegant way to do this, but this change is the most minimal modification to support this.