Implemented utility to work with Request parameters#228
Draft
hurynovich wants to merge 1 commit intotonivade:masterfrom
Draft
Implemented utility to work with Request parameters#228hurynovich wants to merge 1 commit intotonivade:masterfrom
hurynovich wants to merge 1 commit intotonivade:masterfrom
Conversation
aeb5416 to
24027f9
Compare
…fy work with parameters.
24027f9 to
e6d35dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR is a proposal, which adds utility classes to simplify implementation of Commands.
Two main ideas can be distinguished:
CommandException- exception which automatically converted intoErrorRedisToken.ParamsScanner- utility to simplify parameters parsing for Redis queries. And it actively throwsCommandException.Example
Parsing Redis command:
Motivation
I tried to implement few Redis commands with bunch of optional parameters.
And code contains a lot of boiler plate
if/elsestatements when works with rawrequest.getParams().So, at the end I come to utility class which intended to make parameter parsing more concise and readable at the same time.
Note
It is currently a draft.
Tests, naming and docs are not final yet.
Related
#230