API-15 implement runtime serialization and deserialization for new tolk ABI#451
Open
domikedos wants to merge 7 commits intotolk/new-abifrom
Open
API-15 implement runtime serialization and deserialization for new tolk ABI#451domikedos wants to merge 7 commits intotolk/new-abifrom
domikedos wants to merge 7 commits intotolk/new-abifrom
Conversation
domikedos
changed the title
domikedos
changed the title
hsslbchtop
requested changes
Feb 12, 2026
Comment on lines
+72
to
+73
| if u.Prefix.Len > 64 { | ||
| return fmt.Errorf("union prefix length must be less than 64") |
Contributor
There was a problem hiding this comment.
тут ошибка не сходится с условием
либо Len >= 64
либо "be less or equal than 64"
| eatPrefix := ty.Variants[0].PrefixEatInPlace | ||
| if prefixLen > 64 { | ||
| // todo: maybe prefix len can be bigger than 64? | ||
| return fmt.Errorf("union prefix length must be less than 64") |
Contributor
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("union prefix length must be less than 64") | |
| return fmt.Errorf("union prefix length must be less or equal than 64") |
Comment on lines
+41
to
+43
| if val != -35132 { | ||
| t.Errorf("val != -35132, got %v", val) | ||
| } |
Contributor
There was a problem hiding this comment.
nit:
вообще много где удобнее было бы assert.Equal(t, val, -35132) https://pkg.go.dev/github.com/stretchr/testify/assert
Comment on lines
+221
to
+236
| pathPrefix := jsonFilesPath + inputFilename | ||
| actual, err := json.MarshalIndent(v, "", " ") | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| err = os.WriteFile(pathPrefix+".output.json", actual, os.ModePerm) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| expected, err := os.ReadFile(pathPrefix + ".json") | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| if !bytes.Equal(actual, expected) { | ||
| t.Errorf("%s got different results", pathPrefix) | ||
| } |
Contributor
There was a problem hiding this comment.
вынести бы этот повторяющийся кусок
Comment on lines
+3
to
+13
| func ConcatPrefixAndSuffixIfExists(prefix, suffix []byte) []byte { | ||
| if len(suffix) == 0 { | ||
| return prefix | ||
| } | ||
| prefix = prefix[:len(prefix)-1] // remove '}' | ||
| suffix[0] = ',' // replace '{' with ',' | ||
| result := make([]byte, 0, len(prefix)+len(suffix)) | ||
| result = append(result, prefix...) | ||
| result = append(result, suffix...) | ||
| return result | ||
| } |
Contributor
There was a problem hiding this comment.
На всякий prefix бы тоже проверил
Suggested change
| func ConcatPrefixAndSuffixIfExists(prefix, suffix []byte) []byte { | |
| if len(suffix) == 0 { | |
| return prefix | |
| } | |
| prefix = prefix[:len(prefix)-1] // remove '}' | |
| suffix[0] = ',' // replace '{' with ',' | |
| result := make([]byte, 0, len(prefix)+len(suffix)) | |
| result = append(result, prefix...) | |
| result = append(result, suffix...) | |
| return result | |
| } | |
| func ConcatJsonObjects(prefix, suffix []byte) []byte { | |
| if len(suffix) == 0 { | |
| return prefix | |
| } | |
| if len(prefix) == 0 { | |
| return suffix | |
| } | |
| prefix = prefix[:len(prefix)-1] // remove '}' | |
| suffix[0] = ',' // replace '{' with ',' | |
| result := make([]byte, 0, len(prefix)+len(suffix)) | |
| result = append(result, prefix...) | |
| result = append(result, suffix...) | |
| return result | |
| } |
| func (s *Struct) RemoveField(field string) { | ||
| for i, name := range s.fieldNames { | ||
| if name == field { | ||
| s.fieldNames[i] = "|" // impossible symbol for field name in Tolk language |
Contributor
There was a problem hiding this comment.
Это как будто потом нигде не учитывается, зато может повлиять на сравнение и маршалинг, почему не отфильтровать?
Comment on lines
+283
to
+284
| s.fieldNames = append(s.fieldNames, stringKey) | ||
| s.fieldValues = append(s.fieldValues, val) |
Contributor
There was a problem hiding this comment.
Порядок полей в json не гарантируется, если вдруг мы планируем читать json откуда-нибудь еще
| return nil | ||
| } | ||
| } | ||
| // todo: maybe return err? |
Contributor
There was a problem hiding this comment.
Думаю, было бы отлично)
Unknown может быть вполне себе существующим членом енума
|
|
||
| if alias.CustomUnpackFromSlice { | ||
| // todo: maybe simply return error? | ||
| fmt.Println("WARNING! alias has custom unpack method. Default unpacking can be incorrect!") |
Contributor
There was a problem hiding this comment.
Да, лучше ошибку вернуть, если мы не уверены как распаковывать
Comment on lines
+453
to
+454
| // todo: maybe simply return error? | ||
| fmt.Println("WARNING! alias has custom pack method. Default packing can be incorrect!") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.