remove new reddit platform handling #1028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
branch updated to actually remove the lightbox setting and purge it from storage. Also cleaned up the related purges of removed settings - located them all together in a single |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from the "open in new reddit" button that was already handled in #1025, there's not actually a whole lot of dead code we can remove by not supporting new Reddit. We still rely on the combination of TBListener + the oldreddit module for a bunch of UI stuff in old Reddit; eventually #940 will replace both with a new system and everything will be changed to use that instead, but that's not happening here. A couple features specific to new Reddit were removed, and the modbar
overlayFromBarRedesignsetting (which controls whether clicking queue buttons in the modbar on new reddit opens the queue as an overlay or acts as a normal link) now applies to shreddit instead.Fixes #1027