WIP for #716 - "New modmail: Option to always reply as self" #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Work-in-progress pull request for #716 - "New modmail: Option to always reply as self".
Having a seperate toggle for always replying as self would be problematic, because one could run into potentially unexpected behavior if selecting both "always reply as self" and "always reply as subreddit", so I've opted for a toggle which would allow you to default to any of the three reply options, or to leave that setting unchanged from what Reddit defaults it to.
This is a work in progress because I've run into a roadblock I haven't been able to sort out - at some point, Reddit changed the classes for the select, and the old code (lines 104-110) doesn't actually work anymore to be able to use as a guide. The code I've offered as a replacement visually toggles the option, but does not actually trigger the change in reply type which happens if an option on the dropdown is manually clicked.
My proficiency with Javascript is somewhere hovering around "knows just enough to be dangerous", so I'm hoping that what I've provided is useful, and getting this across the finish line will be simple for someone who knows more than me.