Skip to content

Comments

tofu: refresh network name#485

Closed
aborrero wants to merge 1 commit intomainfrom
T389942
Closed

tofu: refresh network name#485
aborrero wants to merge 1 commit intomainfrom
T389942

Conversation

@aborrero
Copy link

The network has a new name.

Bug: T389942

The network has a new name.

Bug: T389942
Signed-off-by: Arturo Borrero Gonzalez <aborrero@wikimedia.org>
@aborrero aborrero requested a review from supertassu March 26, 2025 10:23
Copy link
Member

@supertassu supertassu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you check whether tofu lets this to be changed without re-creating things? this variable is directly fed to the openstack_containerinfra_clustertemplate_v1 resource (without being translated to an ID first)

also, fixed_subnet below is not changing, right?

@aborrero
Copy link
Author

did you check whether tofu lets this to be changed without re-creating things? this variable is directly fed to the openstack_containerinfra_clustertemplate_v1 resource (without being translated to an ID first)

The change is unlikely to require re-creating, as the ID of the network has not changed. The network name is usually a cosmetic thing. This did not require re-creation even in the tofu-infra repository.

In any case I have to say: I did not checked, and I don't plan to. Whoever wants to follow up merging this patch will need to double check.

also, fixed_subnet below is not changing, right?

Correct, this is not changing.

Copy link
Member

@supertassu supertassu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case I have to say: I did not checked, and I don't plan to. Whoever wants to follow up merging this patch will need to double check.

I've not done this, but I'm told someone else has done this. Approving so this can be merged.

@aborrero
Copy link
Author

Please merge this ASAP, otherwise I will close this PR, as I don't want it to show up in my list of pending PRs.

@supertassu
Copy link
Member

Sorry for the delay! We ended up having to re-deploy the cluster so went with a migration to the VXLAN network instead: #491.

@supertassu supertassu closed this Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants