Conversation
The network has a new name. Bug: T389942 Signed-off-by: Arturo Borrero Gonzalez <aborrero@wikimedia.org>
supertassu
left a comment
There was a problem hiding this comment.
did you check whether tofu lets this to be changed without re-creating things? this variable is directly fed to the openstack_containerinfra_clustertemplate_v1 resource (without being translated to an ID first)
also, fixed_subnet below is not changing, right?
The change is unlikely to require re-creating, as the ID of the network has not changed. The network name is usually a cosmetic thing. This did not require re-creation even in the tofu-infra repository. In any case I have to say: I did not checked, and I don't plan to. Whoever wants to follow up merging this patch will need to double check.
Correct, this is not changing. |
supertassu
left a comment
There was a problem hiding this comment.
In any case I have to say: I did not checked, and I don't plan to. Whoever wants to follow up merging this patch will need to double check.
I've not done this, but I'm told someone else has done this. Approving so this can be merged.
|
Please merge this ASAP, otherwise I will close this PR, as I don't want it to show up in my list of pending PRs. |
|
Sorry for the delay! We ended up having to re-deploy the cluster so went with a migration to the VXLAN network instead: #491. |
The network has a new name.
Bug: T389942