Skip to content

String allocations #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ghost1face wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

String allocations #24

ghost1face wants to merge 28 commits into from

Conversation

@ghost1face
Copy link
Contributor

@ghost1face ghost1face commented Dec 24, 2025

Linked Issue

Closes #

Description

Built from #23 and adds enhancements to use ReadOnlySpan<char> instead of .Substring to minimize allocations.

Before review I'd like to create some benchmark tests and charts displaying performance differences

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test coverage improvement

Changes Made

SPEC Compliance

  • This PR implements/fixes spec compliance
  • Spec section(s) affected:
  • Spec version:

Testing

  • All existing tests pass
  • Added new tests for changes
  • Tests cover edge cases and spec compliance

Pre-submission Checklist

  • My code follows the project's coding standards
  • I have run code formatting/linting tools
  • I have added tests that prove my fix/feature works
  • New and existing tests pass locally
  • I have updated documentation if needed
  • I have reviewed the TOON specification for relevant sections

Breaking Changes

  • No breaking changes
  • Breaking changes (describe migration path below)

Additional Context

krlosflipdev and others added 26 commits December 23, 2025 22:22
@krlosflipdev @ghost1face
Implemented Specs v3.0
ecef101
@krlosflipdev @ghost1face
- Removed IsIdentifierSegment and IdentifierPattern from `PathExp…
16d35fb 
…ansion.cs`

- Replaced dot (.) with `Constants.DOT` in `PathExpansion.cs`
- Added `ToonPathExpansionException`
- Updated spec generator aligned to v3.0.0
@krlosflipdev @johannschopplich @ghost1face
Update README.md
64a00e7 
Co-authored-by: Johann Schopplich <johann@schopplich.com>
@krlosflipdev @ghost1face
Fixes
1e079c2 
- Make Encode windows-friendly
- Make SpecGenerator make a clean of tests folder and re-generate the files
- Updated `specgen.sh` aligned to .ps1 file
@krlosflipdev @ghost1face
Revert "Fixes"
1d4f35a 
This reverts commit f3c8e11.
@krlosflipdev @ghost1face
Fixes
db0db15 
- Updated `specgen.sh` as same to ps1 file
- Added exception type validation in `FixtureWriter.cs`
@krlosflipdev @ghost1face
Fixed tests
898b54c
@krlosflipdev @ghost1face
Updated tests
f2f5f48
@krlosflipdev @ghost1face
Fixed tests on windows
4651a38
@ghost1face
feat: Ensure numeric values are fully represented
843c3d9
@ghost1face
feat: Remove LengthMarker references
7bb5305
@ghost1face
chore: Remove unused converters
5358db6
@ghost1face
chore: Test cleanup
b01d468
@ghost1face
chore: Change test project structure, manual tests/specs are no longe…
b1a3501 
…r copied from the SpecGen project
@ghost1face
feat: Test to validate issue #7 is resolved
32a87d9
@ghost1face
chore: Default namespaces to Toon.Format
b21f376
@ghost1face
chore: Regenerate test file for appropriate line endings
e3fa6ad
@ghost1face
Update README.md
9c709b3 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ghost1face
Update README.md
1b1ba37 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ghost1face
chore: Code cleanup based on code review
3a5ef0f
@ghost1face
Merge remote-tracking branch 'origin/full-spec-2' into full-spec-2
38198e8
@ghost1face
fix: Remove unnecessary .ToString invocations
61979dd
@ghost1face
fix: Use AsSpan to minimize string allocations
5511953
@ghost1face
feat: Use Span<char> where possible to minimize allocations
f837253
@ghost1face
chore: Resolve build warning
a1087be
@ghost1face
fix: Use AsSpan to minimize string allocations
34914fc
Base automatically changed from full-spec-2 to main January 14, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Daniel-iel Daniel-iel Daniel-iel approved these changes

Reviewers whose approvals may not affect merge requirements

At least 0 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ghost1face @Daniel-iel @krlosflipdev