feat: Add i18n-context-service to inject custom contexts#383
feat: Add i18n-context-service to inject custom contexts#383jurienhamaker wants to merge 3 commits intotoonvanstrijp:mainfrom
Conversation
|
@toonvanstrijp Have you had any time to look at this yet? |
|
@jurienhamaker I'll take a look at it right now ;) |
|
@jurienhamaker looks good so far, the only thing that I'm not sure about yet is how to make the |
|
@jurienhamaker @jurienhamaker alright I have a potential solution. In the |
|
@toonvanstrijp Any updates? |
|
@toonvanstrijp can you look on this one on your free time. Since this is older and almost mergeable I would like your input. This will help close few issue |
|
Hey @toonvanstrijp, can you check this pull request please!? 🙏 |
|
Or you @rubiin? |
|
plz fix the merge conflicts |
|
can you fix the conflicts and accept the changes to update the version? or can I do this in your pr? |
|
@BARTlab go ahead |
|
@jurienhamaker you're welcome! |
|
I would be interested in these changes as well. It seems to be a feature that can level up this framework to new level. Any plans on merging? |
|
this library is abandoned? |
|
@jurienhamaker apologies for the late reply, would you be able to add tests? |
|
The reply was just a little late, just a little.... |
|
Beter late than never… right? 🤓 |
|
Last time I checked the tests were the only thing keeping from merge, looks like merge conflicts resolution is also needed |
Currently I am working on a project that has a custom request scope.
Similair how this package provides rpc, graphql & http out of the box. This will allow the user to add custom contexts and functions to get the context of said custom context.
I do need some help with the
I18nLangdecorator, since I have no clue how I could inject the service into aparamDecorator.Same for the tests, any suggestions are welcome.