Skip to content

PM- 3026 Update Manage Submissions to accommodate AI workflows #7150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
himaniraghav3 merged 6 commits into from
Nov 26, 2025
Merged

PM- 3026 Update Manage Submissions to accommodate AI workflows #7150

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8f7393c
Update Manage Submissions to accomodate AI Workflows
himaniraghav3 Nov 25, 2025
8d0fae4
Fix linting in css
himaniraghav3 Nov 25, 2025
a293808
Update score link
himaniraghav3 Nov 25, 2025
c2ae9ce
Push updated snapshots
himaniraghav3 Nov 25, 2025
c7d1569
Change icon to button, auto expand first row
himaniraghav3 Nov 26, 2025
70544e5
update test snapshot
himaniraghav3 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion __tests__/shared/components/SubmissionManagement/__snapshots__/ScreeningDetails.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ exports[`Snapshot match 1`] = `
</p>
</div>
<p>
Your submission has been received, and will be evaluated during Review phase.
Your submission has been received and may undergo AI-assisted review during Submission phase. Results will be available for inspection in the review app and final evaluation occurs during Review phase.
<a
className="src-shared-components-SubmissionManagement-ScreeningDetails-___styles__help-link___41Oxm"
href=""
Expand Down
44 changes: 44 additions & 0 deletions __tests__/shared/components/SubmissionManagement/__snapshots__/Submission.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,28 @@ exports[`Snapshot match 1`] = `
type="button"
/>
</Tooltip>
<Tooltip
align={Object {}}
className=""
content={[Function]}
defaultVisible={false}
id=""
onTooltipHover={[Function]}
placeArrow={[Function]}
position="top"
suppressDiv={false}
trigger={
Array [
"hover",
]
}
>
<button
className="src-shared-components-SubmissionManagement-Submission-___styles__download-artifacts-button___2lSi_"
onClick={[Function]}
type="button"
/>
</Tooltip>
<button
className="src-shared-components-SubmissionManagement-Submission-___styles__expand-icon___TDY6Y src-shared-components-SubmissionManagement-Submission-___styles__expanded___8pRX_"
onClick={[Function]}
Expand Down Expand Up @@ -232,6 +254,28 @@ exports[`Snapshot match 2`] = `
type="button"
/>
</Tooltip>
<Tooltip
align={Object {}}
className=""
content={[Function]}
defaultVisible={false}
id=""
onTooltipHover={[Function]}
placeArrow={[Function]}
position="top"
suppressDiv={false}
trigger={
Array [
"hover",
]
}
>
<button
className="src-shared-components-SubmissionManagement-Submission-___styles__download-artifacts-button___2lSi_"
onClick={[Function]}
type="button"
/>
</Tooltip>
<button
className="src-shared-components-SubmissionManagement-Submission-___styles__expand-icon___TDY6Y"
onClick={[Function]}
Expand Down
7 changes: 7 additions & 0 deletions __tests__/shared/components/SubmissionManagement/__snapshots__/SubmissionsTable.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@ exports[`Matches shallow shapshot 1`] = `
className="src-shared-components-SubmissionManagement-SubmissionsTable-___styles__dev-details___2GC2b"
colSpan="6"
>
<div
className="src-shared-components-SubmissionManagement-SubmissionsTable-___styles__workflow-table___WCWMZ"
>
<TableWorkflowRuns
workflowRuns={null}
Copy link

@github-actions github-actions bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
Passing null to workflowRuns might lead to runtime errors if TableWorkflowRuns does not handle null values gracefully. Consider providing a default value or ensuring TableWorkflowRuns can handle null inputs.

/>
</div>
<ScreeningDetails
helpPageUrl=""
onlineReviewUrl=""
Expand Down
3 changes: 3 additions & 0 deletions config/backup-default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,9 @@ module.exports = {
* object should be considered outdated, and updated as soon as possible. */
USER_GROUP_MAXAGE: 24 * 60 * 60 * 1000,

REVIEW_APP_URL: 'https://review.topcoder-dev.com',


Copy link

@github-actions github-actions bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[💡 style]
There are two consecutive blank lines here. While this is not a correctness issue, it could be considered a minor style inconsistency. Consider removing one of the blank lines to maintain a consistent style throughout the file.

/* Maximum time to wait before timeout on searching past challenges (seconds)
* when no result at all.
* Default: 30 seconds.
Expand Down
2 changes: 2 additions & 0 deletions config/default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@ module.exports = {
* This value [seconds] specifies the maximum age after which a group data
* object should be considered outdated, and updated as soon as possible. */
USER_GROUP_MAXAGE: 24 * 60 * 60 * 1000,
REVIEW_APP_URL: 'https://review.topcoder-dev.com',


/* Maximum time to wait before timeout on searching past challenges (seconds)
* when no result at all.
Expand Down
3 changes: 3 additions & 0 deletions config/production.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ module.exports = {
REVIEW_TYPES_API_URL: '/reviewTypes',
REVIEW_SUMMATIONS_API_URL: '/reviewSummations',
},

REVIEW_APP_URL: 'https://review.topcoder.com',

/* Filestack configuration for uploading Submissions
* These are for the production back end */
FILESTACK: {
Expand Down
25 changes: 24 additions & 1 deletion src/shared/actions/page/submission_management.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,35 @@
import _ from 'lodash';
import { redux } from 'topcoder-react-utils';
import { redux, config } from 'topcoder-react-utils';
import { services } from 'topcoder-react-lib';

const Api = services.api.default;

function loadAiWorkflowRunsInit() {}

function loadAiWorkflowRunsDone(tokenV3, submissionId, aiWorkflowId) {
const api = new Api(config.API.V6, tokenV3);
Copy link

@github-actions github-actions bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ security]
Consider validating tokenV3, submissionId, and aiWorkflowId before using them to ensure they are not undefined or null. This can prevent potential runtime errors or security issues.

const url = `/workflows/${aiWorkflowId}/runs?submissionId=${submissionId}`;

return api.get(url)
.then(res => res.json())
Copy link

@github-actions github-actions bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
The use of .then(res => res.json()) assumes that the response will always be JSON. Consider adding error handling for cases where the response might not be JSON, which could lead to runtime errors.

.then(data => ({
submissionId,
aiWorkflowId,
runs: data,
}))
.catch((err) => {
Copy link

@github-actions github-actions bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[💡 maintainability]
Throwing the error directly without any additional context might make debugging difficult. Consider logging the error or adding more context to the error message.

throw err;
});
}

export default redux.createActions({
PAGE: {
SUBMISSION_MANAGEMENT: {
SHOW_DETAILS: _.identity,
CANCEL_DELETE: _.noop,
CONFIRM_DELETE: _.identity,
LOAD_AI_WORKFLOW_RUNS_INIT: loadAiWorkflowRunsInit,
LOAD_AI_WORKFLOW_RUNS_DONE: loadAiWorkflowRunsDone,
},
},
});
2 changes: 1 addition & 1 deletion src/shared/components/SubmissionManagement/ScreeningDetails/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export default function ScreeningDetails(props) {
return {
title: '',
classname: '',
message: 'Your submission has been received, and will be evaluated during Review phase.',
message: 'Your submission has been received and may undergo AI-assisted review during Submission phase. Results will be available for inspection in the review app and final evaluation occurs during Review phase.',
};
};

Expand Down
25 changes: 23 additions & 2 deletions src/shared/components/SubmissionManagement/Submission/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import _ from 'lodash';
import moment from 'moment';
import React from 'react';
import { CHALLENGE_STATUS, COMPETITION_TRACKS, safeForDownload } from 'utils/tc';
import { config } from 'topcoder-react-utils';

import PT from 'prop-types';

Expand All @@ -28,7 +29,6 @@ import ScreeningStatus from '../ScreeningStatus';

import './styles.scss';


export default function Submission(props) {
const {
challenge,
Expand All @@ -48,6 +48,11 @@ export default function Submission(props) {
const safeForDownloadCheck = safeForDownload(submissionObject.url);
const onDownloadArtifacts = onOpenDownloadArtifactsModal.bind(1, submissionObject.id);
const onOpenRatingsList = onOpenRatingsListModal.bind(1, submissionObject.id);
const onOpenReviewApp = () => {
if (!challenge || !challenge.id) return;
const url = `${config.REVIEW_APP_URL}/active-challenges/${challenge.id}/challenge-details?tab=submission`;
Copy link

@github-actions github-actions bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ security]
Consider using encodeURIComponent for challenge.id when constructing the URL to ensure that any special characters are properly encoded. This can prevent potential issues with malformed URLs.

window.open(url, '_blank', 'noopener,noreferrer');
};

// Determine if a challenge is for Topcrowd so we can edit the UI accordingly
let isTopCrowdChallenge = false;
Expand All @@ -58,6 +63,9 @@ export default function Submission(props) {
}
}

console.log('showScreeningDetails updated to:', showScreeningDetails);
Copy link

@github-actions github-actions bot Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ maintainability]
Remove the console.log statement. Debugging logs should not be present in production code as they can clutter the console and potentially expose sensitive information.



return (
<tr styleName="submission-row">
<td styleName="id-col">
Expand Down Expand Up @@ -117,7 +125,7 @@ export default function Submission(props) {
: <span /> }
{ !isTopCrowdChallenge
? (
<Tooltip content={() => <div styleName="tooltip-content">Show Scores</div>}>
<Tooltip content={() => <div styleName="tooltip-content">Show scores</div>}>
<button
onClick={() => onOpenRatingsList()}
type="button"
Expand Down Expand Up @@ -151,6 +159,19 @@ export default function Submission(props) {
</button>
)
}
{ !isTopCrowdChallenge
? (
<Tooltip content={() => <div styleName="tooltip-content">View Review Info</div>}>
<button
onClick={() => onOpenReviewApp()}
type="button"
styleName="review-button"
>
Review
Copy link

@github-actions github-actions bot Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
Consider adding a condition to disable the 'Review' button if safeForDownloadCheck is not true. This would maintain consistency with other buttons that are conditionally rendered based on safeForDownloadCheck.

</button>
</Tooltip>
)
: <span />}
<button
styleName={`expand-icon ${(showScreeningDetails ? 'expanded' : '')}`}
onClick={() => onShowDetails(submissionObject.id)}
Expand Down
7 changes: 7 additions & 0 deletions src/shared/components/SubmissionManagement/Submission/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,16 @@ $submission-space-50: $base-unit * 10;
.download-artifacts-button {
svg {
width: 24px;
fill: $color-turq-160;
}
}

.review-button {
cursor: pointer;
color: $color-turq-160;
font-size: small;
Copy link

@github-actions github-actions bot Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ maintainability]
Consider using a specific font size unit (e.g., px, rem, em) instead of small for font-size to ensure consistent rendering across different browsers and platforms.

}

.download-button {
@include button;

Expand Down
3 changes: 3 additions & 0 deletions src/shared/components/SubmissionManagement/SubmissionManagement/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export default function SubmissionManagement(props) {
submissions,
loadingSubmissions,
showDetails,
submissionWorkflowRuns,
onDelete,
helpPageUrl,
onDownload,
Expand Down Expand Up @@ -182,6 +183,7 @@ export default function SubmissionManagement(props) {
<SubmissionsTable
challenge={challenge}
submissionObjects={submissions}
submissionWorkflowRuns={submissionWorkflowRuns}
showDetails={showDetails}
track={trackName}
status={challenge.status}
Expand Down Expand Up @@ -227,6 +229,7 @@ SubmissionManagement.defaultProps = {
SubmissionManagement.propTypes = {
challenge: PT.shape().isRequired,
showDetails: PT.shape().isRequired,
submissionWorkflowRuns: PT.shape().isRequired,
Copy link

@github-actions github-actions bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ maintainability]
The submissionWorkflowRuns prop is defined as PT.shape().isRequired, but the shape is not specified. Consider defining the shape to ensure that the component receives the expected structure, which can prevent runtime errors and improve maintainability.

onDelete: PT.func,
onlineReviewUrl: PT.string,
helpPageUrl: PT.string,
Expand Down
14 changes: 14 additions & 0 deletions src/shared/components/SubmissionManagement/SubmissionsTable/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import ScreeningDetails from '../ScreeningDetails';
import DownloadArtifactsModal from '../DownloadArtifactsModal';
import Submission from '../Submission';
import RatingsListModal from '../RatingsListModal';
import TableWorkflowRuns from '../TableWorkflowRuns';

import './styles.scss';

Expand All @@ -35,6 +36,7 @@ export default function SubmissionsTable(props) {
const {
challenge,
submissionObjects,
submissionWorkflowRuns,
showDetails,
track,
onDelete,
Expand Down Expand Up @@ -92,12 +94,22 @@ export default function SubmissionsTable(props) {
/>
);
submissionsWithDetails.push(submission);
const workflowRunsForSubmission = submissionWorkflowRuns
&& submissionWorkflowRuns[subObject.id]
? submissionWorkflowRuns[subObject.id]
: null;

const submissionDetail = (
<tr key={subObject.id} styleName="submission-row">
{showDetails[subObject.id]
&& (
<td colSpan="6" styleName="dev-details">
<div styleName="workflow-table">
<TableWorkflowRuns
workflowRuns={workflowRunsForSubmission}
/>
</div>

<ScreeningDetails
screeningObject={subObject.screening}
helpPageUrl={helpPageUrl}
Expand Down Expand Up @@ -186,10 +198,12 @@ SubmissionsTable.defaultProps = {
onlineReviewUrl: '',
helpPageUrl: '',
getSubmissionScores: _.noop,
submissionWorkflowRuns: [],
Copy link

@github-actions github-actions bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
The default value for submissionWorkflowRuns is set to an empty array, but its prop type is defined as a shape. This mismatch could lead to unexpected behavior. Consider setting the default value to an empty object {} to align with the prop type.

};

SubmissionsTable.propTypes = {
challenge: PT.shape().isRequired,
submissionWorkflowRuns: PT.shape(),
Copy link

@github-actions github-actions bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ maintainability]
The submissionWorkflowRuns prop type is defined as PT.shape(), which is not specific enough. Consider defining the shape of this object to ensure that the expected structure is enforced, improving maintainability and reducing potential runtime errors.

submissionObjects: PT.arrayOf(SubShape),
showDetails: PT.shape().isRequired,
track: PT.string.isRequired,
Expand Down
6 changes: 6 additions & 0 deletions src/shared/components/SubmissionManagement/SubmissionsTable/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@ $submission-space-50: $base-unit * 10;
border-top: 0;
padding-top: 0;

.workflow-table {
@media (max-width: 768px) {
display: none;
}
}

.upload-artifact-btn {
@include roboto-medium;

Expand Down
Loading
Loading