Skip to content

PM-3026 Update tab for checkpoint submissions #7153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
himaniraghav3 merged 1 commit into from
Nov 27, 2025
Merged

PM-3026 Update tab for checkpoint submissions #7153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/shared/components/SubmissionManagement/Submission/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ export default function Submission(props) {
const onOpenRatingsList = onOpenRatingsListModal.bind(1, submissionObject.id);
const onOpenReviewApp = () => {
if (!challenge || !challenge.id) return;
const url = `${config.REVIEW_APP_URL}/active-challenges/${challenge.id}/challenge-details?tab=submission`;
const tab = submissionObject.type === 'CHECKPOINT_SUBMISSION' || submissionObject.type === 'CONTEST_SUBMISSION'
Copy link

@github-actions github-actions bot Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ maintainability]
Consider using a constant or enum for submission types like 'CHECKPOINT_SUBMISSION' and 'CONTEST_SUBMISSION' to avoid magic strings and improve maintainability.

? 'checkpoint-submission'
: 'submission';
const url = `${config.REVIEW_APP_URL}/active-challenges/${challenge.id}/challenge-details?tab=${tab}`;
window.open(url, '_blank', 'noopener,noreferrer');
};

Expand Down
Loading