PM-1612 Update visible columns on copilot applications#1185
PM-1612 Update visible columns on copilot applications#1185himaniraghav3 merged 1 commit intodevfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| {activeTab === CopilotDetailsTabViews.details && <OpportunityDetails opportunity={opportunity} />} | ||
| {activeTab === CopilotDetailsTabViews.applications && isAdminOrPM && opportunity && ( | ||
| {activeTab === CopilotDetailsTabViews.applications && opportunity && ( |
There was a problem hiding this comment.
The isAdminOrPM prop is being passed to CopilotApplications, but the condition isAdminOrPM has been removed from the check for rendering this component. Ensure that the logic for selectively visible columns is correctly implemented within CopilotApplications based on this prop.
|
|
||
| const tableData = useMemo(getData, [props.copilotApplications, props.members]) | ||
|
|
||
| const visibleColumns = props.isAdminOrPM |
There was a problem hiding this comment.
Consider renaming visibleColumns to filteredColumns or userSpecificColumns for clarity, as it indicates that the columns are filtered based on user roles.
|
|
||
| const visibleColumns = props.isAdminOrPM | ||
| ? tableColumns | ||
| : tableColumns.filter(col => 
2 participants
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-1612
What's in this PR?
The Applications tab is now visible to all
The columns however have been made selectively visible to Admins/PMs