PM-1504 edit create scorecard by vas3a · Pull Request #1196 · topcoder-platform/platform-ui

vas3a · 2025-08-19T12:15:35Z

Related JIRA Ticket:

https://topcoder.atlassian.net/browse/PM-1504 - Create/Edit Scorecard UI

What's in this PR?

Added page for edit/create scorecard

…reate-scorecard

src/apps/review/src/lib/components/TableScorecards/TableScorecards.tsx

src/apps/review/src/lib/hooks/useFetchScorecard.ts

github-actions · 2025-08-19T12:15:57Z

src/apps/review/src/lib/hooks/useFetchScorecard.ts

+
+interface ScorecardResponse {
+  scorecard: Scorecard | undefined
+  error?: any


Consider specifying a more precise type for error instead of using any to improve type safety and clarity.

src/apps/review/src/lib/hooks/useFetchScorecard.ts

src/apps/review/src/lib/models/Scorecard.model.ts

github-actions · 2025-08-19T12:16:09Z

src/apps/review/src/pages/scorecards/EditScorecardPage/EditScorecardPage.context.tsx

+}
+
+export type EditScorecardPageContextValue = {
+    confirm: (prosp: ConfirmationProps) => Promise<boolean>,


Typo in parameter name: prosp should be props.

src/apps/review/src/pages/scorecards/EditScorecardPage/EditScorecardPage.context.tsx

src/apps/review/src/pages/scorecards/EditScorecardPage/EditScorecardPage.module.scss

src/apps/review/src/pages/scorecards/EditScorecardPage/EditScorecardPage.tsx

github-actions · 2025-08-19T12:16:19Z

src/apps/review/src/pages/scorecards/EditScorecardPage/EditScorecardPage.tsx

+    }, [params.scorecardId, navigate])
+
+    if (scorecardQuery.isValidating) {
+        return <></>


Returning an empty fragment when scorecardQuery.isValidating is true might not provide the best user experience. Consider displaying a loading indicator to inform users that data is being fetched.

src/apps/review/src/pages/scorecards/EditScorecardPage/components/BasicSelect.tsx

...ps/review/src/pages/scorecards/EditScorecardPage/components/CalculatedWeightsSum.module.scss

src/apps/review/src/pages/scorecards/EditScorecardPage/components/CalculatedWeightsSum.tsx

src/apps/review/src/pages/scorecards/EditScorecardPage/components/InputWrapper.module.scss

github-actions · 2025-08-19T12:16:39Z

src/apps/review/src/pages/scorecards/EditScorecardPage/components/InputWrapper.tsx

+    }): ReactElement {
+        // Expecting a single React element as children (the input)
+        if (!props.children || Array.isArray(props.children)) {
+            return <></>


The check for Array.isArray(props.children) might not be sufficient to ensure that props.children is a single React element. Consider using React.Children.only to enforce that props.children is a single child.

src/apps/review/src/pages/scorecards/EditScorecardPage/components/InputWrapper.tsx

github-actions · 2025-08-19T12:16:43Z

src/apps/review/src/pages/scorecards/EditScorecardPage/components/ScorecardGroupForm.tsx

+                    name: yup.string()
+                        .required('Group name is required'),
+                    weight: yup
+                        .number()


Consider using .positive('Weight must be a positive number') instead of .min(0, 'Weight must be at least 0') for clarity and consistency in validation messages.

src/apps/review/src/pages/scorecards/EditScorecardPage/components/ScorecardGroupForm.tsx

src/apps/review/src/pages/scorecards/EditScorecardPage/components/ScorecardInfoForm.tsx

src/apps/review/src/pages/scorecards/EditScorecardPage/components/ScorecardQuestionForm.tsx

src/apps/review/src/pages/scorecards/EditScorecardPage/components/ScorecardSectionForm.tsx

src/apps/review/src/pages/scorecards/EditScorecardPage/utils.ts

github-actions · 2025-08-19T12:17:05Z

src/apps/review/src/pages/scorecards/EditScorecardPage/utils.ts

+        if (!items?.length) return false
+        const sum = items.reduce((acc, g) => acc + (Number(g.weight) || 0), 0)
+
+        if (sum !== 100) {


The condition if (sum !== 100) should use the value parameter instead of hardcoding 100. Change it to if (sum !== value) to ensure the function behaves correctly with different values.

src/apps/review/src/pages/scorecards/ScorecardsListPage/ScorecardsListPage.tsx

src/libs/ui/lib/components/button/base-button/BaseButton.module.scss

src/libs/ui/lib/components/button/base-button/BaseButton.tsx

src/libs/ui/lib/components/form/form-groups/form-input/input-textarea/InputTextarea.tsx

src/libs/ui/lib/components/form/form-groups/form-input/input-wrapper/InputWrapper.tsx

github-actions · 2025-08-19T12:17:29Z

src/libs/ui/lib/components/form/form-groups/form-input/input-wrapper/InputWrapper.tsx

    readonly hideInlineErrors?: boolean
    readonly hint?: string
-    readonly label: string | JSX.Element
+    readonly label?: string | JSX.Element


The label prop has been changed from required to optional. Verify that the component can handle cases where label is undefined, as this might impact accessibility or user experience.

src/libs/ui/lib/styles/variables/_spacing.scss

…i into PM-1504_edit-create-scorecard

github-actions · 2025-08-19T16:20:23Z

src/apps/review/src/lib/hooks/useFetchScorecard.ts

-        `${baseUrl}/scorecards/${id}`,
+    const { data, error, isValidating }: SWRResponse<Scorecard, any> = useSWR<Scorecard>(
+        // eslint-disable-next-line unicorn/no-null
+        id ? `${baseUrl}/scorecards/${id}` : null,


The URL path has been changed from \${baseUrl}/${id}`to`${baseUrl}/scorecards/${id}``. Ensure that this change is intentional and that the backend API endpoint supports this new path. If the endpoint has changed, verify that all related documentation and tests are updated accordingly.

src/apps/review/src/pages/scorecards/ViewScorecardPage/ViewScorecardPage.tsx

vas3a added 7 commits August 18, 2025 15:36

PM-1504 - create & edit scorecards

48ad7df

PM-1504 - style scorecard edit page

fb23cc8

PM-1504 - styling & validation

a03833f

eslint fixes

aca4a92

Merge remote-tracking branch 'origin/feat/review' into PM-1504_edit-c…

7cf1633

…reate-scorecard

Add breadcrumbs to edit scorecard, link to new scorecard

dbc4ec7

cancel button

680a7a5

vas3a requested review from hentrymartin, himaniraghav3 and kkartunov August 19, 2025 12:15