Skip to content

fix(PM-1503): QA feedbacks in view scorecard page #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkartunov merged 7 commits into from
Aug 21, 2025
Merged

fix(PM-1503): QA feedbacks in view scorecard page #1201

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1a1b695
fix: qa feedbacks in view scorecard page
hentrymartin Aug 20, 2025
8590e5b
fix: qa feedbacks in view scorecard page
hentrymartin Aug 20, 2025
b84183c
fix: qa feedbacks in view scorecard page
hentrymartin Aug 20, 2025
de5daee
fix: changed error message
hentrymartin Aug 20, 2025
ead5de8
fix: changed error message
hentrymartin Aug 20, 2025
1afb702
fix: lint
hentrymartin Aug 20, 2025
e960d77
fix: lint
hentrymartin Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...view/src/pages/scorecards/ViewScorecardPage/ScorecardDetails/ScorecardDetails.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import '@libs/ui/styles/includes';

.container {
display: flex;
flex-direction: row;
Expand Down Expand Up @@ -50,4 +52,10 @@
flex-direction: column;
}
}
}

@media (max-width: #{$lg-max}) {
.container {
flex-direction: column;
}
}
Copy link

@github-actions github-actions bot Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to add a newline at the end of the file to ensure consistency across different systems and tools that may process this file.

4 changes: 2 additions & 2 deletions ...review/src/pages/scorecards/ViewScorecardPage/ScorecardGroups/ScorecardGroups.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
.group {
.heading {
.groupInfo {
flex-direction: column;
flex-direction: row;
.name {
margin-bottom: 8px;
margin-bottom: 0px;
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions ...ew/src/pages/scorecards/ViewScorecardPage/ScorecardSections/ScorecardSections.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,9 @@
.section {
.heading {
.sectionInfo {
flex-direction: column;
flex-direction: row;
.name {
margin-bottom: 4px;
margin-bottom: 0px;
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/apps/review/src/pages/scorecards/ViewScorecardPage/ViewScorecardPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ const ViewScorecardPage: FC = () => {
const { profile }: ProfileContextData = useContext(profileContext)
const isAdmin = profile?.roles.includes(UserRole.administrator)
const breadCrumb = useMemo(
() => [{ index: 1, label: 'Scorecards', path: '/review/scorecard' }, { index: 2, label: 'Scorecards Details' }],
() => [{ index: 1, label: 'Scorecards', path: '/scorecard' }, { index: 2, label: 'Scorecards Details' }],
[],
)

const scorecardQuery = useFetchScorecard(scorecardId)

return (
<PageWrapper
pageTitle='Software General Review Scorecard'
pageTitle={(scorecardQuery.scorecard && scorecardQuery.scorecard.name) || ''}
breadCrumb={breadCrumb}
rightHeader={isAdmin && (
<LinkButton
Expand Down
15 changes: 8 additions & 7 deletions src/apps/review/src/review-app.routes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ export const reviewRoutes: ReadonlyArray<PlatformRoute> = [
route: activeReviewAssigmentsRouteId,
},
{
authRequired: true,
children: [
{
authRequired: true,
Expand All @@ -110,21 +109,23 @@ export const reviewRoutes: ReadonlyArray<PlatformRoute> = [
route: '',
},
{
authRequired: false,
element: <ViewScorecardPage />,
id: 'view-scorecard-page',
route: ':scorecardId',
},
{
authRequired: true,
element: <EditScorecardPage />,
id: 'edit-scorecard-page',
route: ':scorecardId/edit',
},
{
authRequired: true,
element: <EditScorecardPage />,
id: 'new-scorecard-page',
route: 'new',
},
{
authRequired: false,
element: <ViewScorecardPage />,
id: 'view-scorecard-page',
route: ':scorecardId',
},

],
element: <ScorecardsContainer />,
Expand Down
1 change: 1 addition & 0 deletions src/libs/core/lib/router/router-context/router.context-provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ export const RouterProvider: FC<RouterProviderProps> = (props: RouterProviderPro
}

function getRouteElement(route: PlatformRoute): JSX.Element {
console.log(route, 'asd.lkasdl')
// create the route element
const routeElement: JSX.Element = !route.authRequired
? route.element
Expand Down