Skip to content

fix(PM-1614): add white space below copilot request table #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hentrymartin merged 2 commits into from
Aug 21, 2025
Merged

fix(PM-1614): add white space below copilot request table #1204

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2db5f5e
fix: add white space below copilot request table
hentrymartin Aug 21, 2025
f1bcccd
fix: lint
hentrymartin Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/apps/copilots/src/pages/copilot-requests/CopilotRequestsPage.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
@import '@libs/ui/styles/includes';

.shortPage {
margin-bottom: 250px;
}

.tableWrapper {
margin-bottom: 60px;
}

.actionButtons {
display: flex;
gap: $sp-1;
Expand Down
5 changes: 4 additions & 1 deletion src/apps/copilots/src/pages/copilot-requests/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,9 @@ const CopilotRequestsPage: FC = () => {
isValidating: requestsLoading,
hasMoreCopilotRequests,
setSize,
size }: CopilotRequestsResponse = useCopilotRequests(sort)
size,
page
Copy link

@github-actions github-actions bot Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page variable is added to the destructuring assignment but is not used anywhere in the code. Consider removing it if it's not needed, or ensure it is utilized appropriately.

}: CopilotRequestsResponse = useCopilotRequests(sort)

const viewRequestDetails = useMemo(() => (
routeParams.requestId && find(requests, { id: +routeParams.requestId }) as CopilotRequest
Expand Down Expand Up @@ -265,6 +267,7 @@ const CopilotRequestsPage: FC = () => {
>
<PageTitle>Copilot Requests</PageTitle>
<Table
className={(page === 1 && tableData.length < 10) ? styles.shortPage : styles.tableWrapper}
columns={tableColumns}
data={tableData}
moreToLoad={hasMoreCopilotRequests}
Expand Down
3 changes: 2 additions & 1 deletion src/apps/copilots/src/services/copilot-requests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export type CopilotRequestsResponse = {
isValidating: boolean;
size: number;
setSize: (size: number) => void;
page: number;
}

/**
Expand Down Expand Up @@ -77,7 +78,7 @@ export const useCopilotRequests = (sort: Sort, projectId?: string): CopilotReque
const copilotRequests = data.flatMap(page => page.data)
const hasMoreCopilotRequests = latestPage.page + 1 < latestPage.totalPages

return { data: copilotRequests, hasMoreCopilotRequests, isValidating, setSize: (s: number) => { setSize(s) }, size }
return { data: copilotRequests, hasMoreCopilotRequests, isValidating, setSize: (s: number) => { setSize(s) }, size, page: latestPage.page }
}

export type CopilotRequestResponse = SWRResponse<CopilotRequest, CopilotRequest>
Expand Down