Skip to content

PM-2631 - allow checkpoint reviewers to see reviews #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vas3a merged 1 commit into from
Jan 13, 2026
Merged

PM-2631 - allow checkpoint reviewers to see reviews #1394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/apps/review/src/lib/components/ChallengeDetailsContent/TabContentReview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,12 @@ export const TabContentReview: FC<Props> = (props: Props) => {
},
[challengeInfo?.status],
)

const isSubmitterView = actionChallengeRole === SUBMITTER
&& selectedTab !== APPROVAL

const hasPassedReviewThreshold = useMemo(
() => hasSubmitterPassedThreshold(
() => !isSubmitterView || hasSubmitterPassedThreshold(
providedReviews ?? [],
myOwnedMemberIds,
props.reviewMinimumPassingScore,
Expand Down Expand Up @@ -673,8 +677,6 @@ export const TabContentReview: FC<Props> = (props: Props) => {
&& actionChallengeRole === REVIEWER

// show loading ui when fetching data
const isSubmitterView = actionChallengeRole === SUBMITTER
&& selectedTab !== APPROVAL
const reviewRows = isSubmitterView
? (shouldSortReviewTabByScore ? submitterRowsForReviewTab : filteredSubmitterReviews)
: (shouldSortReviewTabByScore ? reviewerRowsForReviewTab : filteredReviews)
Expand Down
Loading