Skip to content

Remove operation conflict check from newversion executor#696

Merged
joaobologna merged 1 commit intomainfrom
fix/scheduler-conflict-check
Nov 26, 2025
Merged

Remove operation conflict check from newversion executor#696
joaobologna merged 1 commit intomainfrom
fix/scheduler-conflict-check

Conversation

@joaobologna
Copy link
Contributor

@joaobologna joaobologna commented Nov 24, 2025

Note

When creating a new scheduler version inside the executor, directly enqueues a switchversion operation without conflict checks and adds a unit test for this behavior.

  • Schedulers Service (scheduler_manager.go):
    • In CreateNewSchedulerVersionAndEnqueueSwitchVersion, replace EnqueueSwitchActiveVersionOperation with direct operationManager.CreateOperation using switchversion.Definition, skipping conflict checks (documented in comments).
  • Tests (scheduler_manager_test.go):
    • Add TestCreateNewSchedulerVersionAndEnqueueSwitchVersion to validate enqueueing switchversion without conflict checks inside a transaction.

Written by Cursor Bugbot for commit 5f71f86. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@joaobologna joaobologna merged commit f0b6284 into main Nov 26, 2025
14 of 15 checks passed
@joaobologna joaobologna deleted the fix/scheduler-conflict-check branch November 26, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants