Skip to content

fix: properly handling timeout when revoking ETCD lease#419

Merged
rsafonseca merged 5 commits intomainfrom
fix/etcd-revoke-lease
Nov 21, 2025
Merged

fix: properly handling timeout when revoking ETCD lease#419
rsafonseca merged 5 commits intomainfrom
fix/etcd-revoke-lease

Conversation

@reinaldooli
Copy link
Contributor

This is a cherrypick from the changes made here.
Since pitaya v3 still using ETCD, these changes needs to be propagated.

@reinaldooli reinaldooli self-assigned this Aug 19, 2024
@coveralls
Copy link

coveralls commented Aug 19, 2024

Pull Request Test Coverage Report for Build 19576959475

Details

  • 5 of 28 (17.86%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 58.999%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cluster/etcd_service_discovery.go 0 7 0.0%
pkg/groups/memory_group_service.go 0 7 0.0%
pkg/cluster/nats_rpc_server.go 5 14 35.71%
Files with Coverage Reduction New Missed Lines %
pkg/modules/binary.go 2 78.26%
Totals Coverage Status
Change from base Build 19575651066: -0.06%
Covered Lines: 5068
Relevant Lines: 8590

💛 - Coveralls

@rsafonseca rsafonseca merged commit ae70432 into main Nov 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants