Skip to content

Skip computing changed files on pull_request event #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paneq wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Skip computing changed files on pull_request event #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52b1a40
Revert "Output HTML as well to use it as GHA artifact"
paneq Oct 10, 2025
44a8b73
Skip computing changed files on pull_request event
paneq Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 3 additions & 22 deletions dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

36 changes: 3 additions & 33 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,6 @@ export async function run(): Promise<void> {

const event = github.context.eventName;
let changedFiles = '';
let baseRef: string | undefined;
let headRef: string | undefined;
let isPullRequest = false;
let pullRequestNumber: number | undefined;

Expand All @@ -237,35 +235,8 @@ export async function run(): Promise<void> {
isPullRequest = true;
pullRequestNumber = pullRequest.number;

// Get list of changed files in PR
baseRef = pullRequest.base.ref;
headRef = pullRequest.head.ref;

if (!baseRef || !headRef) {
throw new Error(
'Unable to determine base or head references from pull request',
);
}

// Validate baseRef and headRef to prevent option injection
validateGitRef(baseRef);
validateGitRef(headRef);

await gitInterface.fetch(['--', 'origin', baseRef]);
const baseFetchHead = (
await gitInterface.revparse(['FETCH_HEAD'])
).trim();

await gitInterface.fetch(['--', 'origin', headRef]);
const headFetchHead = (
await gitInterface.revparse(['FETCH_HEAD'])
).trim();

changedFiles = await gitInterface.diff([
'--name-only',
baseFetchHead,
headFetchHead,
]);
// This code here somehow was getting stuck on "Getting changed files" forever.
// Removing it as it is not necessary. We rely on GitHub's own detection of changed files.
} else if (event === 'workflow_dispatch') {
core.info('Running in workflow_dispatch mode');

Expand Down Expand Up @@ -454,8 +425,7 @@ export async function run(): Promise<void> {
core.endGroup();

const outputFile = path.join(workingDirectory, 'output.json');
const outputFileHtml = path.join(workingDirectory, 'output.html');
let promptfooArgs = ['eval', '-c', configPath, '-o', outputFile, '-o', outputFileHtml];
let promptfooArgs = ['eval', '-c', configPath, '-o', outputFile];
if (!useConfigPrompts && promptFiles.length > 0) {
promptfooArgs = promptfooArgs.concat(['--prompts', ...promptFiles]);
}
Expand Down