Add German (de) translations for E3DC RSCP integration#305
Add German (de) translations for E3DC RSCP integration#305
Conversation
Co-authored-by: torbennehmer <2812067+torbennehmer@users.noreply.github.com>
torbennehmer
left a comment
There was a problem hiding this comment.
Der Betriebsmodus idle ist im Sinne von Bereitschaft gemeint
There was a problem hiding this comment.
Pull request overview
Adds German (de) translations for the E3DC RSCP Home Assistant integration to localize config flows, entities, selectors, and services.
Changes:
- Added a full German translation file for the integration UI strings.
- Localized entity names/states, selector options, and service descriptions/fields.
- Reused Home Assistant common key references for standard config fields/errors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "power-mode": { | ||
| "name": "Modus", | ||
| "state": { | ||
| "0": "Leerlauf", | ||
| "1": "Entladung", | ||
| "2": "Ladung" | ||
| } | ||
| }, |
There was a problem hiding this comment.
The numeric mappings for power-mode vs selector.power_mode are inconsistent (e.g., "0" is Leerlauf in the sensor state map but Normalbetrieb in the selector options). If these represent the same underlying enum, this will cause incorrect labels in the UI. Align the mappings to the integration’s actual enum values (or rename one of the keys if they are intentionally different concepts).
There was a problem hiding this comment.
Give me more context: what's the English original and where is it used
| "selector": { | ||
| "power_mode": { | ||
| "options": { | ||
| "0": "Normalbetrieb", | ||
| "1": "Leerlauf", | ||
| "2": "Entladung", | ||
| "3": "Ladung", | ||
| "4": "Netzladung" | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
The numeric mappings for power-mode vs selector.power_mode are inconsistent (e.g., "0" is Leerlauf in the sensor state map but Normalbetrieb in the selector options). If these represent the same underlying enum, this will cause incorrect labels in the UI. Align the mappings to the integration’s actual enum values (or rename one of the keys if they are intentionally different concepts).
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot Give me more context: what's the English original and where is it used for the comments you added above |
Co-authored-by: torbennehmer <2812067+torbennehmer@users.noreply.github.com>
Changed "Leerlauf" to "Bereitschaft" for idle state in commit 08baa39. The translation now correctly uses "Bereitschaft" (standby/ready) instead of "Leerlauf" for the idle operating mode.
The English originals are: power-mode sensor (3-state):
pset-powermode sensor (5-state):
selector.power_mode (used in service UI):
I had incorrectly mixed the state mappings. Fixed in commit 08baa39 - the mappings now match correctly, with "Bereitschaft" for idle. |
German Translation for E3DC Integration
Checklist:
Summary:
✅ Complete German translation created with 593 lines
✅ All 100% of English strings translated to German
✅ Industry-standard German terminology used for solar/battery systems
✅ Home Assistant conventions followed
✅ JSON structure validated and matches English file exactly
✅ Power mode state mappings corrected
✅ Changed "Leerlauf" to "Bereitschaft" for idle state
Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.