Skip to content

TWE-1 - BE - New homepage hero fields#313

Merged
SharmaineLim merged 12 commits intointegration/2024-evolutionfrom
feature/twe-1-homepage-hero-fields
Dec 18, 2024
Merged

TWE-1 - BE - New homepage hero fields#313
SharmaineLim merged 12 commits intointegration/2024-evolutionfrom
feature/twe-1-homepage-hero-fields

Conversation

@SharmaineLim
Copy link
Collaborator

@SharmaineLim SharmaineLim commented Dec 4, 2024

Link to Ticket

Description of Changes Made

This PR replaces the current introduction text field with a rich text field, and adds 2 new fields for the heading shown in the hero area of the homepage.

Styling will be done in a separate ticket.

How to Test

  1. Apply the migrations.
  2. Edit the homepage.
  3. You should see the new fields.
  4. Editing the new fields should display the new content on the preview.

Screenshots

Editor

image

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Updated
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@SharmaineLim SharmaineLim marked this pull request as ready for review December 5, 2024 06:20
@SharmaineLim SharmaineLim requested a review from ababic December 5, 2024 08:21
Copy link
Member

@helenb helenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SharmaineLim I have tested and all working as expected. I have a question on the decision to use markdown instead of rich text for the title though.

Will leave with @ababic to review as well.

@helenb
Copy link
Member

helenb commented Dec 6, 2024

I've not re-tested as my build has gone screwy again... but looking good - just one last query on the markup for the purple and pink text.

@SharmaineLim SharmaineLim force-pushed the feature/twe-1-homepage-hero-fields branch from 72bcae5 to e2c76a3 Compare December 18, 2024 06:51
@SharmaineLim SharmaineLim merged commit 4400045 into integration/2024-evolution Dec 18, 2024
4 checks passed
@SharmaineLim SharmaineLim deleted the feature/twe-1-homepage-hero-fields branch December 18, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants