Skip to content

Filter listings by whether the page is public#320

Merged
helenb merged 3 commits intomainfrom
fix/exclude_protected_pages_from_listings
Dec 18, 2024
Merged

Filter listings by whether the page is public#320
helenb merged 3 commits intomainfrom
fix/exclude_protected_pages_from_listings

Conversation

@helenb
Copy link
Member

@helenb helenb commented Dec 17, 2024

Requested by Lily:

"I published a blog with a password to share with a client so they could see how it would look on our blog, but I didn't want it to show up in our blog section (it's the RNIB Yellow Mode blog). Is there a way I can remove it from the listing page here but keep it password protected for the client?"

Description of Changes Made

Update blog page and work page listings to exclude password protected pages, including the filtered listings.

How to Test

On a local build, test the blog listing and work page listings function correctly and do not show any password protected pages. Ensure that the filtered listings also exclude any password protected pages.

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@helenb helenb marked this pull request as ready for review December 17, 2024 15:46
@helenb helenb requested a review from engineervix December 17, 2024 15:46
Copy link
Member

@engineervix engineervix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, thank you @helenb and @zerolab

@helenb helenb merged commit 1a98458 into main Dec 18, 2024
4 checks passed
@helenb helenb deleted the fix/exclude_protected_pages_from_listings branch December 18, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants