TWE-2 - FE - Division signpost block#323
TWE-2 - FE - Division signpost block#323albinazs merged 10 commits intointegration/2024-evolutionfrom
Conversation
...ject_styleguide/templates/patterns/molecules/streamfield/blocks/division_signpost_block.html
Show resolved
Hide resolved
|
@albinazs it would be good to make sure all the accessibility checks are covered for each FE pr - not sure if you still have some in progress? |
|
I am getting some issues with the |
|
@helenb We've discussed with Ben E. the necessary changes for the automated tests to pass and have increased the type scale for the project. The code is also cleaned |
...ject_styleguide/templates/patterns/molecules/streamfield/blocks/division_signpost_block.html
Outdated
Show resolved
Hide resolved
...ject_styleguide/templates/patterns/molecules/streamfield/blocks/division_signpost_block.html
Outdated
Show resolved
Hide resolved
...ject_styleguide/templates/patterns/molecules/streamfield/blocks/division_signpost_block.html
Outdated
Show resolved
Hide resolved
| &--theme-coral { | ||
| background-color: var(--color--coral-charity); | ||
|
|
||
| &:has(.button-link:hover) { |
There was a problem hiding this comment.
Praise: This is one of my favourite things to come to CSS recently! So powerful : )
chris-lawton
left a comment
There was a problem hiding this comment.
Nice work @albinazs - this is looking great! I wonder if it we should add it to the styleguide?
|
Thank you, @chris-lawton - that was fast! |
Link to Ticket
Based on #314
Description of Changes Made
Designed division signpost block
Additional FE changes (discussed separately with Ben E.):
The theme colors code will be cleaned up in TWE-6 and TWE-22
How to Test
Check in the DPL: http://0.0.0.0:8000/pattern-library/render-pattern/patterns/molecules/streamfield/blocks/division_signpost_block.html
Screenshots
Expand to see more
Screen.Recording.2024-12-19.at.1.52.42.PM.mov
MR Checklist
Unit tests
Documentation
Browser testing
Data protection
Light and dark mode
Accessibility
Sustainability
Pattern library