Move GTM id from env to wagtail settings, and add experimental secondary GTM id#427
Move GTM id from env to wagtail settings, and add experimental secondary GTM id#427
Conversation
engineervix
left a comment
There was a problem hiding this comment.
Thanks @helenb I've reviewed the changes and they look good to me.
Just a thought (non-blocking) on the template, I wonder whether it'd make sense to create a template include for the GTM markup, so that it's defined in one place and we don't repeat ourselves. Then we'd just pass the tag manager ID when including it.
Good idea! |
I might leave for now, till we know whether we want to rename the dataLayer or not for the second tag. |
Description of Changes Made
Request via slack to add a secondary GTM container. Advice seems to be mixed about whether this is a good idea, and whether the
dataLayershould be renamed if a second container is used. Putting this on staging so that Olly can experiment.How to Test
Screenshots
Expand to see more
MR Checklist
Unit tests
Documentation
Browser testing
Data protection
Light and dark mode
Accessibility
Sustainability
Pattern library