Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
ianmeigh
left a comment
ianmeigh
left a comment
There was a problem hiding this comment.
Hi @nickmoreton, Left a few suggestions.
| python{39,310,311,312}-django{42}-wagtail{52,63,64,70} | ||
| python{39,310,311,312}-django{51,52}-wagtail{63,64,70} | ||
| python313-django{51,52}-wagtail{63,64,70} |
There was a problem hiding this comment.
Suggestions:
- Remove Wagtail 5.2 from the matrix (EOL).
- Remove Python 3.9 as Django 5.1+ doesn't list it as a supported version.
- Add Python 3.13 earlier, as supported by upper-bound versions.
| python{39,310,311,312}-django{42}-wagtail{52,63,64,70} | |
| python{39,310,311,312}-django{51,52}-wagtail{63,64,70} | |
| python313-django{51,52}-wagtail{63,64,70} | |
| python{39,310,311,312}-django{42}-wagtail{63,64,70} | |
| python{310,311,312,313}-django{51,52}-wagtail{63,64,70} |
| django42: Django>=4.2,<4.3 | ||
| django51: Django>=5.1,<5.2 | ||
| django52: Django>=5.2,<5.3 | ||
| wagtail52: wagtail>=5.2,<5.3 |
There was a problem hiding this comment.
Suggestion: Remove Wagtail 5.2 (EOL).
| wagtail52: wagtail>=5.2,<5.3 |
| django: ["django>=4.2,<4.3", "django>=5.1,<5.2", "django>=5.2,<5.3"] | ||
| wagtail: | ||
| [ | ||
| "wagtail>=5.2,<5.3", |
There was a problem hiding this comment.
Remove Wagtail 5.2 as it has reached EOL.
| "wagtail>=5.2,<5.3", |
There was a problem hiding this comment.
Suggestion: Remove Wagtail 5 from the classifiers.
| # Django 5.1/5.2 with Wagtail 5.2 combinations are excluded for all Python versions | ||
| - django: "django>=5.1,<5.2" | ||
| wagtail: "wagtail>=5.2,<5.3" |
There was a problem hiding this comment.
Suggestion: Remove Wagtail 5.2 (EOL).
| # Django 5.1/5.2 with Wagtail 5.2 combinations are excluded for all Python versions | |
| - django: "django>=5.1,<5.2" | |
| wagtail: "wagtail>=5.2,<5.3" |
| - django: "django>=5.2,<5.3" | ||
| wagtail: "wagtail>=5.2,<5.3" | ||
|
|
There was a problem hiding this comment.
Suggestion: Remove Wagtail 5.2 (EOL).
| - django: "django>=5.2,<5.3" | |
| wagtail: "wagtail>=5.2,<5.3" |
Thanks @ianmeigh I did wonder if 5.2 could be dropped but thought we could let @kevinhowbrook make a decision about it. I just had a feeling it's OK left like that just now. |
3 participants
This pull request updates the project's testing matrix, dependencies, and configuration files.
Testing matrix updates:
.github/workflows/test.yml) to include Django 5.2 and Wagtail 7.0 in the testing matrix, while removing older Wagtail versions (6.0–6.2). Excluded incompatible combinations, such as Python 3.13 with Django 4.2 and certain Wagtail versions.Dependency and configuration updates:
CHANGELOG.mdto reflect support for Django 5.1/5.2, Wagtail 7.0, and Python 3.9–3.13, while dropping support for Python < 3.9. Added a note about the newtoxconfiguration.tox-poetrywithtoxin thesetup.pyfile to align with the testing setup.tox.inifile to define environments for local testing with combinations of Python (3.9–3.13), Django (4.2–5.2), and Wagtail (5.2–7.0).