[walnascar] fix some recipes incompatibilites from imx and freescale layers#473
Open
EdTheBearded wants to merge 2 commits intotorizon:walnascarfrom
Open
[walnascar] fix some recipes incompatibilites from imx and freescale layers#473EdTheBearded wants to merge 2 commits intotorizon:walnascarfrom
EdTheBearded wants to merge 2 commits intotorizon:walnascarfrom
Conversation
S was pointing to a different directory, and license-checksum was failing
for not finding the license file.
Now S = ${UNPACKDIR}, and license-checksum is passing.
Related-to: TOR-4193
Signed-off-by: Eduardo Ferreira <eduardo.barbosa@toradex.com>
S was pointing to a different directory, and license-checksum was failing
for not finding the license file.
Now S = ${UNPACKDIR}, and license-checksum is passing.
Signed-off-by: Eduardo Ferreira <eduardo.barbosa@toradex.com>
EdTheBearded
requested review from
Freireg,
MatheusRodrigues-tor,
Copilot and
rborn-tx
There was a problem hiding this comment.
Pull request overview
This PR adjusts Yocto dynamic-layer metadata to address recipe incompatibilities when building with the NXP i.MX ML and Freescale ML layers (TOR-4193 context), mainly by aligning the expected source directory (S) with where BitBake unpacks git fetches.
Changes:
- Add bbappends for
pytorch(meta-imx-ml) andssat(meta-freescale-ml) to setS = "${UNPACKDIR}/git". - Register
meta-freescale-mlpatterns inBBFILES_DYNAMICso the new dynamic-layer content is discovered/activated when that external layer is present.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dynamic-layers/meta-imx-ml/recipes-libraries/pytorch/pytorch_%.bbappend | Forces S to ${UNPACKDIR}/git for pytorch builds from git sources. |
| dynamic-layers/meta-freescale-ml/recipes-nnstreamer/ssat/ssat_%.bbappend | Forces S to ${UNPACKDIR}/git for ssat builds from git sources. |
| conf/layer.conf | Adds BBFILES_DYNAMIC entries for meta-freescale-ml so its dynamic bbappends are picked up. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
MatheusRodrigues-tor
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related-to: TOR-4193