Fixed the bug that the handler cannot get the main thread context on the Windows platform.#3479
Merged
bdarnell merged 6 commits intotornadoweb:masterfrom May 14, 2025
Conversation
Contributor
Author
|
@bdarnell , hello! My pull request has been open for a while, and I would appreciate it if you could take a look. Thank you very much for your contributions to this project! I look forward to your feedback. |
Member
|
Thanks and sorry for the delay. The change looks good, but would you mind adding a simple test case for it? |
Contributor
Author
@bdarnell I tried to add a test case, please review. |
Member
|
Merge or rebase onto current master to fix the tox issues. This is ready to merge as soon as we get a clean CI run. |
bdarnell
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
platform
windows
minimal reproducible demo
Run and visit http://localhost:8888, then print default