Skip to content

Make sure that the in-operator on HTTPHeaders is case insensitive #3563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdarnell merged 1 commit into from
Dec 15, 2025
+5 −1
Merged

Make sure that the in-operator on HTTPHeaders is case insensitive #3563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tornado/httputil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,8 @@ def __contains__(self, name: object) -> bool:
# in __getitem__ when it's not needed.
if not isinstance(name, str):
return False
return name in self._as_list
norm_name = _normalize_header(name)
return norm_name in self._as_list

def __getitem__(self, name: str) -> str:
header = _normalize_header(name)
Expand Down
3 changes: 3 additions & 0 deletions tornado/test/httputil_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,9 @@ def test_multi_line(self):
sorted(list(headers.get_all())),
[("Asdf", "qwer zxcv"), ("Foo", "bar baz"), ("Foo", "even more lines")],
)
# Verify case insensitivity in-operator
self.assertTrue("asdf" in headers)
self.assertTrue("Asdf" in headers)

def test_continuation(self):
data = "Foo: bar\r\n\tasdf"
Expand Down