Fix NameError and socket leak in TCPClient._create_stream error path#3579
Open
bysiber wants to merge 1 commit intotornadoweb:masterfrom
Open
Fix NameError and socket leak in TCPClient._create_stream error path#3579bysiber wants to merge 1 commit intotornadoweb:masterfrom
bysiber wants to merge 1 commit intotornadoweb:masterfrom
Conversation
If IOStream() constructor raises OSError, the except handler references 'stream' which was never assigned, causing a NameError that masks the original error. Also close the socket to prevent a resource leak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
TCPClient._create_stream, ifIOStream()constructor raisesOSError, the except handler referencesstreamwhich was never assigned:This causes a
NameErrorthat masks the originalOSError, making it impossible to diagnose the root cause from the traceback.Additionally the socket object would be leaked since it's never closed in the error path.
Fixed by returning the
socket_objinstead of the undefinedstreamvariable, and closing the socket before returning.