New API endpoint for listing users#788
Merged
josecelano merged 14 commits intotorrust:developfrom Jan 22, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #788 +/- ##
===========================================
- Coverage 48.85% 48.53% -0.33%
===========================================
Files 111 111
Lines 8288 8413 +125
Branches 8288 8413 +125
===========================================
+ Hits 4049 4083 +34
- Misses 4101 4192 +91
Partials 138 138 ☔ View full report in Codecov by Sentry. |
b44d54f to
f48c4a2
Compare
490eb1e to
453f02d
Compare
453f02d to
5ff61f4
Compare
5ff61f4 to
e8bd16d
Compare
590b20b to
b44ea9b
Compare
josecelano
approved these changes
Jan 22, 2025
Member
josecelano
left a comment
There was a problem hiding this comment.
Hi @mario-nt it looks good! I think you could also add some tests like the ones we have for the torrent context. You can do it in a new PR.
josecelano
requested changes
Jan 22, 2025
Member
josecelano
left a comment
There was a problem hiding this comment.
@mario-nt the testing workflow is failing.
81198c9 to
1c62a9e
Compare
josecelano
approved these changes
Jan 22, 2025
Member
|
ACK 1c62a9e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue #658
Resolves #796