feat: add ProfileName domain type for LXD profile validation and environment isolation

- Create ProfileName domain type with LXD naming validation (1-63 chars, ASCII letters/numbers/dashes, no leading digit/dash, no trailing dash)
- Add ProfileName field to Environment entity for environment-specific profile naming
- Update Config struct to include ProfileName parameter
- Integrate ProfileName throughout template rendering pipeline
- Update VariablesContext and VariablesContextBuilder to use ProfileName type instead of String
- Add profile_name template variable to OpenTofu variables and main.tf
- Update E2E test cleanup to use environment-specific profile names
- Add comprehensive unit tests for ProfileName validation
- Ensure type safety and domain validation for LXD profile names
- Enable proper environment isolation between E2E test runs

This resolves LXD profile conflicts between different test environments by ensuring
each environment uses its own uniquely named profile (e.g., torrust-profile-e2e-provision,
torrust-profile-e2e-full) instead of sharing a single hardcoded profile name.

Author: josecelano

src/application/commands/provision.rs

@@ -23,6 +23,8 @@ use crate::application::steps::{
     RenderOpenTofuTemplatesStep, ValidateInfrastructureStep, WaitForCloudInitStep,
     WaitForSSHConnectivityStep,
 };
+#[allow(unused_imports)]
+use crate::domain::ProfileName;
 use crate::infrastructure::adapters::ansible::AnsibleClient;
 #[allow(unused_imports)]
 use crate::infrastructure::adapters::lxd::InstanceName;
@@ -206,6 +208,7 @@ mod tests {
             ssh_credentials.clone(),
             InstanceName::new("torrust-tracker-vm".to_string())
                 .expect("Valid hardcoded instance name"), // TODO: Make this configurable in Phase 3
+            ProfileName::new("default-profile".to_string()).expect("Valid hardcoded profile name"), // TODO: Make this configurable in Phase 3
         ));
 
         let ansible_renderer = Arc::new(AnsibleTemplateRenderer::new(

src/bin/e2e_provision_tests.rs

@@ -45,12 +45,9 @@ use tracing::{error, info};
 // Import E2E testing infrastructure
 use torrust_tracker_deploy::domain::{Environment, EnvironmentName};
 use torrust_tracker_deploy::e2e::context::{TestContext, TestContextType};
-use torrust_tracker_deploy::e2e::tasks::{
-    preflight_cleanup::cleanup_lingering_resources,
-    virtual_machine::{
-        cleanup_infrastructure::cleanup_infrastructure,
-        run_provision_command::run_provision_command,
-    },
+use torrust_tracker_deploy::e2e::tasks::virtual_machine::{
+    cleanup_infrastructure::cleanup_infrastructure, preflight_cleanup::cleanup_lingering_resources,
+    run_provision_command::run_provision_command,
 };
 use torrust_tracker_deploy::logging::{self, LogFormat};
 use torrust_tracker_deploy::shared::Username;

src/bin/e2e_tests_full.rs

@@ -54,11 +54,11 @@ use tracing::{error, info};
 use torrust_tracker_deploy::domain::{Environment, EnvironmentName};
 use torrust_tracker_deploy::e2e::context::{TestContext, TestContextType};
 use torrust_tracker_deploy::e2e::tasks::{
-    preflight_cleanup::cleanup_lingering_resources,
     run_configure_command::run_configure_command,
     run_test_command::run_test_command,
     virtual_machine::{
         cleanup_infrastructure::cleanup_infrastructure,
+        preflight_cleanup::cleanup_lingering_resources,
         run_provision_command::run_provision_command,
     },
 };

src/config/mod.rs

@@ -16,7 +16,7 @@
 
 use std::path::PathBuf;
 
-pub use crate::domain::InstanceName;
+pub use crate::domain::{InstanceName, ProfileName};
 pub use crate::shared::ssh::{SshConnection, SshCredentials};
 
 /// Configuration parameters for deployment environments.
@@ -48,6 +48,12 @@ pub struct Config {
     /// cannot end with dash.
     pub instance_name: InstanceName,
 
+    /// Name for the LXD profile to be created.
+    ///
+    /// This name will be used for creating LXD profiles with environment-specific
+    /// naming to ensure test isolation between different environments.
+    pub profile_name: ProfileName,
+
     /// Subdirectory name for Ansible-related files within the build directory.
     ///
     /// Ansible playbooks, inventory files, and configuration templates
@@ -90,17 +96,20 @@ impl Config {
     /// # use std::net::{IpAddr, Ipv4Addr};
     /// # use std::path::PathBuf;
     /// # use torrust_tracker_deploy::config::{Config, SshCredentials, InstanceName};
+    /// # use torrust_tracker_deploy::domain::ProfileName;
     /// # use torrust_tracker_deploy::shared::Username;
     /// let ssh_credentials = SshCredentials::new(
     ///     PathBuf::from("/home/user/.ssh/deploy_key"),
     ///     PathBuf::from("/home/user/.ssh/deploy_key.pub"),
     ///     Username::new("ubuntu").unwrap(),
     /// );
     /// let instance_name = InstanceName::new("my-instance".to_string()).unwrap();
+    /// let profile_name = ProfileName::new("my-profile".to_string()).unwrap();
     /// let config = Config::new(
     ///     true,                           // keep environment for debugging
     ///     ssh_credentials,
     ///     instance_name,
+    ///     profile_name,
     ///     "templates".to_string(),
     ///     PathBuf::from("/path/to/project"),
     ///     PathBuf::from("/path/to/project/build"),
@@ -111,6 +120,7 @@ impl Config {
         keep_env: bool,
         ssh_config: SshCredentials,
         instance_name: InstanceName,
+        profile_name: ProfileName,
         templates_dir: String,
         project_root: PathBuf,
         build_dir: PathBuf,
@@ -119,6 +129,7 @@ impl Config {
             keep_env,
             ssh_credentials: ssh_config,
             instance_name,
+            profile_name,
             ansible_subfolder: "ansible".to_string(),
             opentofu_subfolder: "tofu/lxd".to_string(),
             templates_dir,

src/container.rs

@@ -56,7 +56,8 @@ impl Services {
             template_manager.clone(),
             config.build_dir.clone(),
             config.ssh_credentials.clone(),
-            config.instance_name.clone(), // Phase 3: Use instance_name from config instead of hardcoded value
+            config.instance_name.clone(),
+            config.profile_name.clone(),
         );
 
         // Create configuration template renderer

src/domain/environment.rs

@@ -37,7 +37,7 @@
 //! ```
 
 use crate::config::InstanceName;
-use crate::domain::EnvironmentName;
+use crate::domain::{EnvironmentName, ProfileName};
 use crate::shared::Username;
 use serde::{Deserialize, Serialize};
 use std::path::PathBuf;
@@ -75,6 +75,9 @@ pub struct Environment {
     /// The instance name for this environment (auto-generated)
     instance_name: InstanceName,
 
+    /// The profile name for this environment (auto-generated)
+    profile_name: ProfileName,
+
     /// SSH username for connecting to instances in this environment
     ssh_username: Username,
 
@@ -147,13 +150,19 @@ impl Environment {
         let instance_name = InstanceName::new(instance_name_str)
             .expect("Generated instance name should always be valid");
 
+        // Generate profile name: torrust-profile-{env_name}
+        let profile_name_str = format!("torrust-profile-{env_str}");
+        let profile_name = ProfileName::new(profile_name_str)
+            .expect("Generated profile name should always be valid");
+
         // Generate environment-specific directories
         let data_dir = PathBuf::from("data").join(env_str);
         let build_dir = PathBuf::from("build").join(env_str);
 
         Self {
             name,
             instance_name,
+            profile_name,
             ssh_username,
             ssh_private_key_path,
             ssh_public_key_path,
@@ -174,6 +183,15 @@ impl Environment {
         &self.instance_name
     }
 
+    /// Returns the profile name for this environment
+    ///
+    /// Returns the unique LXD profile name based on the environment name
+    /// to ensure profile isolation between different test environments.
+    #[must_use]
+    pub fn profile_name(&self) -> &ProfileName {
+        &self.profile_name
+    }
+
     /// Returns the SSH username for this environment
     #[must_use]
     pub fn ssh_username(&self) -> &Username {

src/domain/mod.rs

@@ -8,15 +8,18 @@
 //! - `environment` - Environment entity encapsulating all environment-specific configuration
 //! - `environment_name` - Environment name validation and management
 //! - `instance_name` - LXD instance name validation and management
+//! - `profile_name` - LXD profile name validation and management
 //! - `template` - Core template domain models and business logic
 
 pub mod environment;
 pub mod environment_name;
 pub mod instance_name;
+pub mod profile_name;
 pub mod template;
 
 // Re-export commonly used domain types for convenience
 pub use environment::Environment;
 pub use environment_name::{EnvironmentName, EnvironmentNameError};
 pub use instance_name::{InstanceName, InstanceNameError};
+pub use profile_name::{ProfileName, ProfileNameError};
 pub use template::{TemplateEngine, TemplateEngineError, TemplateManager, TemplateManagerError};