fix: update GitHub workflows for environment-specific directory structure and naming

- Update test-e2e-provision.yml to use build/e2e-provision/tofu/lxd instead of build/tofu/lxd
- Update container and profile names to use environment-specific naming (torrust-tracker-vm-e2e-provision, torrust-profile-e2e-provision)
- Update test-lxd-provision.yml to use temporary directory /tmp/lxd-provision-test instead of build/ to separate standalone infrastructure tests from app logic
- Use static container names torrust-tracker-vm-test and torrust-profile-test for infrastructure validation
- Update test-e2e-config.yml cleanup to target specific container torrust-tracker-vm-e2e-config instead of removing all containers
- Add safety fallback cleanup comments explaining testcontainers automatic cleanup behavior
- Ensure proper cleanup of environment-specific profiles in addition to containers

These changes align GitHub workflows with the new ProfileName domain type integration
and environment-specific naming conventions, preventing workflow failures due to
hardcoded paths and container names that no longer match the application structure.

Author: josecelano

.github/workflows/test-e2e-config.yml

@@ -109,8 +109,12 @@ jobs:
         if: always()
         run: |
           echo "Cleaning up test containers..."
-          # Clean up any remaining containers from the test
-          docker ps -aq | xargs -r docker rm -f || echo "No containers to remove"
+          # This is a safety fallback cleanup in case testcontainers cleanup didn't complete
+          # properly (e.g., if the test was abruptly halted). Under normal circumstances,
+          # the testcontainers crate should automatically clean up containers when tests finish.
+
+          # Clean up the specific container created for e2e-config tests
+          docker rm -f torrust-tracker-vm-e2e-config 2>/dev/null || echo "Container torrust-tracker-vm-e2e-config not found or already removed"
 
           # Clean up any test images if needed
           docker images --filter "reference=torrust-provisioned-instance*" -q | xargs -r docker rmi -f || echo "No test images to remove"

.github/workflows/test-e2e-provision.yml

@@ -68,16 +68,16 @@ jobs:
 
       - name: Get test outputs (on success)
         if: success()
-        working-directory: build/tofu/lxd
+        working-directory: build/e2e-provision/tofu/lxd
         run: |
           echo "=== Infrastructure Outputs ==="
           sudo -E tofu output || echo "No outputs available"
 
           echo "=== Container Status ==="
-          sudo lxc list torrust-tracker-vm || echo "Container not found"
+          sudo lxc list torrust-tracker-vm-e2e-provision || echo "Container not found"
 
           # Check if the container has an IP address before proceeding
-          sudo lxc info torrust-tracker-vm || echo "Container info not available"
+          sudo lxc info torrust-tracker-vm-e2e-provision || echo "Container info not available"
 
       - name: Debug information (on failure)
         if: failure()
@@ -86,7 +86,7 @@ jobs:
           sudo lxc list || echo "LXC list failed"
 
           echo "=== OpenTofu State ==="
-          cd build/tofu/lxd
+          cd build/e2e-provision/tofu/lxd
           sudo -E tofu show || echo "No state to show"
 
           echo "=== System Resources ==="
@@ -98,13 +98,14 @@ jobs:
 
       - name: Cleanup infrastructure (always run)
         if: always()
-        working-directory: build/tofu/lxd
+        working-directory: build/e2e-provision/tofu/lxd
         run: |
           echo "Cleaning up test infrastructure..."
           # Use sudo for CI environment cleanup
           # NOTE: For local development, use "sg lxd -c 'tofu destroy'" instead
           sudo -E tofu destroy -auto-approve || echo "Destroy command failed or nothing to destroy"
-          sudo lxc delete torrust-tracker-vm --force || echo "Container deletion failed or container doesn't exist"
+          sudo lxc delete torrust-tracker-vm-e2e-provision --force || echo "Container deletion failed or container doesn't exist"
+          sudo lxc profile delete torrust-profile-e2e-provision || echo "Profile deletion failed or profile doesn't exist"
 
       - name: Final verification
         if: always()

.github/workflows/test-lxd-provision.yml

@@ -64,11 +64,26 @@ jobs:
         run: |
           # Build the template system and render the static templates
           cargo build --release
-          # For this workflow, we use static fixtures without variables for testing
-          mkdir -p build
-          cp -r templates/* build/
+
+          # Create a temporary directory for this standalone infrastructure test
+          # This test is independent of the deployment app logic and should not
+          # use the same build directory structure
+          TEMP_DIR="/tmp/lxd-provision-test"
+          echo "Using temporary directory: $TEMP_DIR"
+
+          # Set up LXD test configuration in temp directory
+          mkdir -p "$TEMP_DIR/lxd"
+          cp -r templates/tofu/lxd/* "$TEMP_DIR/lxd/"
+
           # Override the dynamic cloud-init template with static fixture
-          cp fixtures/tofu/lxd/cloud-init.yml build/tofu/lxd/cloud-init.yml
+          cp fixtures/tofu/lxd/cloud-init.yml "$TEMP_DIR/lxd/cloud-init.yml"
+
+          # Create static variables for this infrastructure test
+          cat > "$TEMP_DIR/lxd/variables.tfvars" << EOF
+          instance_name = "torrust-tracker-vm-test"
+          profile_name = "torrust-profile-test"
+          image = "ubuntu:24.04"
+          EOF
 
       - name: Verify installations
         run: |
@@ -82,19 +97,19 @@ jobs:
           lxc list
 
       - name: Initialize OpenTofu
-        working-directory: build/tofu/lxd
+        working-directory: /tmp/lxd-provision-test/lxd
         run: tofu init
 
       - name: Validate OpenTofu configuration
-        working-directory: build/tofu/lxd
+        working-directory: /tmp/lxd-provision-test/lxd
         run: tofu validate
 
       - name: Plan deployment
-        working-directory: build/tofu/lxd
+        working-directory: /tmp/lxd-provision-test/lxd
         run: tofu plan
 
       - name: Apply configuration
-        working-directory: build/tofu/lxd
+        working-directory: /tmp/lxd-provision-test/lxd
         run: |
           # Use tofu without sudo since socket permissions are set up
           # NOTE: For local development, use "sg lxd -c 'tofu apply'" instead
@@ -158,12 +173,12 @@ jobs:
           lxc exec torrust-tracker-vm -- systemctl status ssh || echo "ssh service check failed"
 
       - name: Get container outputs
-        working-directory: build/tofu/lxd
+        working-directory: /tmp/lxd-provision-test/lxd
         run: tofu output
 
       - name: Cleanup
         if: always()
-        working-directory: build/tofu/lxd
+        working-directory: /tmp/lxd-provision-test/lxd
         run: |
           echo "Cleaning up container..."
           # Use tofu without sudo since socket permissions are set up