refactor: prepare commands for Phase 5 state management integration

This commit completes Subtask 1 of Phase 5: Preparatory Refactoring.

Changes:

- Refactor ProvisionCommand structure:
  * Extract 5 helper methods from execute() for better clarity
  * Organize methods: public interface first, then private helpers
  * Remove confusing 'Phase' terminology from comments
  * Methods: render_opentofu_templates, create_instance, get_instance_info,
    render_ansible_templates, wait_for_readiness

- Remove redundant SshCredentials field:
  * Pass ssh_credentials as parameter to execute() instead
  * Update all callers (E2E tests)

- Add error context extraction helpers:
  * extract_failed_step() to identify which step failed
  * extract_opentofu_step() for OpenTofu-specific error context
  * Add 6 unit tests for error extraction

- Add Phase 5 integration markers:
  * TODO(Phase 5) comments in ProvisionCommand and ConfigureCommand
  * Document where state transitions will be integrated

- Setup repository infrastructure:
  * Create RepositoryFactory for environment-specific repository creation
  * Add repository_factory field to Services container
  * Extract REPOSITORY_LOCK_TIMEOUT_SECS constant (30 seconds)
  * Add 5 tests for RepositoryFactory (4 unit + 1 integration)

- Code quality improvements:
  * Add 'clonable' to project-words.txt
  * Add missing backticks in documentation
  * Run rustfmt for consistent formatting

All 703 tests passing, all linters passing.
Ready for Phase 5 Subtasks 2-4.

Author: josecelano

project-words.txt

@@ -7,6 +7,7 @@ buildx
 chdir
 childlogdir
 clippy
+clonable
 cloneable
 cloudinit
 connrefused

src/application/commands/configure.rs

@@ -20,8 +20,19 @@ pub enum ConfigureCommandError {
 /// This command handles all steps required to configure infrastructure:
 /// 1. Install Docker
 /// 2. Install Docker Compose
+///
+/// # TODO(Phase 5): State Management Integration
+///
+/// When implementing state management in Phase 5:
+/// 1. Add `repository: Arc<dyn EnvironmentRepository>` field
+/// 2. Update `new()` to accept repository parameter
+/// 3. Change `execute()` to accept `Environment<Provisioned>` instead of no parameters
+/// 4. Return `Environment<Configured>` instead of `()`
+/// 5. Add state transitions and persistence calls at marked points in `execute()`
 pub struct ConfigureCommand {
     ansible_client: Arc<AnsibleClient>,
+    // TODO(Phase 5): Add repository field here
+    // repository: Arc<dyn EnvironmentRepository>,
 }
 
 impl ConfigureCommand {
@@ -49,10 +60,19 @@ impl ConfigureCommand {
             "Starting complete infrastructure configuration workflow"
         );
 
+        // TODO(Phase 5): Transition to Configuring state and persist
+        // let environment = environment.start_configuring();
+        // self.persist_state(&environment)?;
+
         InstallDockerStep::new(Arc::clone(&self.ansible_client)).execute()?;
 
         InstallDockerComposeStep::new(Arc::clone(&self.ansible_client)).execute()?;
 
+        // TODO(Phase 5): Transition to Configured state and persist
+        // let configured_env = environment.complete_configuring();
+        // self.persist_state(&configured_env)?;
+        // return Ok(configured_env);
+
         info!(
             command = "configure",
             "Infrastructure configuration completed successfully"