refactor: add loggin setup to all integration tests

Author: josecelano

tests/common/logging.rs

@@ -16,9 +16,9 @@ pub fn captured_logs_buffer() -> &'static Mutex<CircularBuffer> {
     CAPTURED_LOGS_GLOBAL_BUFFER.get_or_init(|| Mutex::new(CircularBuffer::new(1000, 200)))
 }
 
-pub fn setup(filter: LevelFilter) {
+pub fn setup() {
     INIT.call_once(|| {
-        tracing_init(filter, &TraceStyle::Default);
+        tracing_init(LevelFilter::ERROR, &TraceStyle::Default);
     });
 }
 

tests/servers/api/v1/contract/authentication.rs

@@ -1,5 +1,4 @@
 use torrust_tracker_test_helpers::configuration;
-use tracing::level_filters::LevelFilter;
 
 use crate::common::http::{Query, QueryParam};
 use crate::common::logging::{self};
@@ -9,6 +8,8 @@ use crate::servers::api::Started;
 
 #[tokio::test]
 async fn should_authenticate_requests_by_using_a_token_query_param() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     let token = env.get_connection_info().api_token.unwrap();
@@ -24,7 +25,7 @@ async fn should_authenticate_requests_by_using_a_token_query_param() {
 
 #[tokio::test]
 async fn should_not_authenticate_requests_when_the_token_is_missing() {
-    logging::setup(LevelFilter::ERROR);
+    logging::setup();
 
     let env = Started::new(&configuration::ephemeral().into()).await;
 
@@ -39,7 +40,7 @@ async fn should_not_authenticate_requests_when_the_token_is_missing() {
 
 #[tokio::test]
 async fn should_not_authenticate_requests_when_the_token_is_empty() {
-    logging::setup(LevelFilter::ERROR);
+    logging::setup();
 
     let env = Started::new(&configuration::ephemeral().into()).await;
 
@@ -54,7 +55,7 @@ async fn should_not_authenticate_requests_when_the_token_is_empty() {
 
 #[tokio::test]
 async fn should_not_authenticate_requests_when_the_token_is_invalid() {
-    logging::setup(LevelFilter::ERROR);
+    logging::setup();
 
     let env = Started::new(&configuration::ephemeral().into()).await;
 
@@ -69,6 +70,8 @@ async fn should_not_authenticate_requests_when_the_token_is_invalid() {
 
 #[tokio::test]
 async fn should_allow_the_token_query_param_to_be_at_any_position_in_the_url_query() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     let token = env.get_connection_info().api_token.unwrap();

tests/servers/api/v1/contract/context/auth_key.rs

@@ -3,7 +3,6 @@ use std::time::Duration;
 use serde::Serialize;
 use torrust_tracker::core::auth::Key;
 use torrust_tracker_test_helpers::configuration;
-use tracing::level_filters::LevelFilter;
 
 use crate::common::logging::{self};
 use crate::servers::api::connection_info::{connection_with_invalid_token, connection_with_no_token};
@@ -17,6 +16,8 @@ use crate::servers::api::{force_database_error, Started};
 
 #[tokio::test]
 async fn should_allow_generating_a_new_random_auth_key() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     let response = Client::new(env.get_connection_info())
@@ -39,6 +40,8 @@ async fn should_allow_generating_a_new_random_auth_key() {
 
 #[tokio::test]
 async fn should_allow_uploading_a_preexisting_auth_key() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     let response = Client::new(env.get_connection_info())
@@ -61,7 +64,7 @@ async fn should_allow_uploading_a_preexisting_auth_key() {
 
 #[tokio::test]
 async fn should_not_allow_generating_a_new_auth_key_for_unauthenticated_users() {
-    logging::setup(LevelFilter::ERROR);
+    logging::setup();
 
     let env = Started::new(&configuration::ephemeral().into()).await;
 
@@ -88,7 +91,7 @@ async fn should_not_allow_generating_a_new_auth_key_for_unauthenticated_users()
 
 #[tokio::test]
 async fn should_fail_when_the_auth_key_cannot_be_generated() {
-    logging::setup(LevelFilter::ERROR);
+    logging::setup();
 
     let env = Started::new(&configuration::ephemeral().into()).await;
 
@@ -108,6 +111,8 @@ async fn should_fail_when_the_auth_key_cannot_be_generated() {
 
 #[tokio::test]
 async fn should_allow_deleting_an_auth_key() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     let seconds_valid = 60;
@@ -135,6 +140,8 @@ async fn should_fail_generating_a_new_auth_key_when_the_provided_key_is_invalid(
         pub seconds_valid: u64,
     }
 
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     let invalid_keys = [
@@ -172,6 +179,8 @@ async fn should_fail_generating_a_new_auth_key_when_the_key_duration_is_invalid(
         pub seconds_valid: String,
     }
 
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     let invalid_key_durations = [
@@ -199,6 +208,8 @@ async fn should_fail_generating_a_new_auth_key_when_the_key_duration_is_invalid(
 
 #[tokio::test]
 async fn should_fail_deleting_an_auth_key_when_the_key_id_is_invalid() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     let invalid_auth_keys = [
@@ -222,7 +233,7 @@ async fn should_fail_deleting_an_auth_key_when_the_key_id_is_invalid() {
 
 #[tokio::test]
 async fn should_fail_when_the_auth_key_cannot_be_deleted() {
-    logging::setup(LevelFilter::ERROR);
+    logging::setup();
 
     let env = Started::new(&configuration::ephemeral().into()).await;
 
@@ -246,7 +257,7 @@ async fn should_fail_when_the_auth_key_cannot_be_deleted() {
 
 #[tokio::test]
 async fn should_not_allow_deleting_an_auth_key_for_unauthenticated_users() {
-    logging::setup(LevelFilter::ERROR);
+    logging::setup();
 
     let env = Started::new(&configuration::ephemeral().into()).await;
 
@@ -283,6 +294,8 @@ async fn should_not_allow_deleting_an_auth_key_for_unauthenticated_users() {
 
 #[tokio::test]
 async fn should_allow_reloading_keys() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     let seconds_valid = 60;
@@ -300,7 +313,7 @@ async fn should_allow_reloading_keys() {
 
 #[tokio::test]
 async fn should_fail_when_keys_cannot_be_reloaded() {
-    logging::setup(LevelFilter::ERROR);
+    logging::setup();
 
     let env = Started::new(&configuration::ephemeral().into()).await;
 
@@ -321,7 +334,7 @@ async fn should_fail_when_keys_cannot_be_reloaded() {
 
 #[tokio::test]
 async fn should_not_allow_reloading_keys_for_unauthenticated_users() {
-    logging::setup(LevelFilter::ERROR);
+    logging::setup();
 
     let env = Started::new(&configuration::ephemeral().into()).await;
 
@@ -350,7 +363,6 @@ mod deprecated_generate_key_endpoint {
 
     use torrust_tracker::core::auth::Key;
     use torrust_tracker_test_helpers::configuration;
-    use tracing::level_filters::LevelFilter;
 
     use crate::common::logging::{self};
     use crate::servers::api::connection_info::{connection_with_invalid_token, connection_with_no_token};
@@ -363,6 +375,8 @@ mod deprecated_generate_key_endpoint {
 
     #[tokio::test]
     async fn should_allow_generating_a_new_auth_key() {
+        logging::setup();
+
         let env = Started::new(&configuration::ephemeral().into()).await;
 
         let seconds_valid = 60;
@@ -382,7 +396,7 @@ mod deprecated_generate_key_endpoint {
 
     #[tokio::test]
     async fn should_not_allow_generating_a_new_auth_key_for_unauthenticated_users() {
-        logging::setup(LevelFilter::ERROR);
+        logging::setup();
 
         let env = Started::new(&configuration::ephemeral().into()).await;
 
@@ -405,6 +419,8 @@ mod deprecated_generate_key_endpoint {
 
     #[tokio::test]
     async fn should_fail_generating_a_new_auth_key_when_the_key_duration_is_invalid() {
+        logging::setup();
+
         let env = Started::new(&configuration::ephemeral().into()).await;
 
         let invalid_key_durations = [
@@ -426,7 +442,7 @@ mod deprecated_generate_key_endpoint {
 
     #[tokio::test]
     async fn should_fail_when_the_auth_key_cannot_be_generated() {
-        logging::setup(LevelFilter::ERROR);
+        logging::setup();
 
         let env = Started::new(&configuration::ephemeral().into()).await;
 

tests/servers/api/v1/contract/context/health_check.rs

@@ -1,11 +1,14 @@
 use torrust_tracker::servers::apis::v1::context::health_check::resources::{Report, Status};
 use torrust_tracker_test_helpers::configuration;
 
+use crate::common::logging;
 use crate::servers::api::v1::client::get;
 use crate::servers::api::Started;
 
 #[tokio::test]
 async fn health_check_endpoint_should_return_status_ok_if_api_is_running() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     let url = format!("http://{}/api/health_check", env.get_connection_info().bind_address);

tests/servers/api/v1/contract/context/stats.rs

@@ -4,7 +4,6 @@ use bittorrent_primitives::info_hash::InfoHash;
 use torrust_tracker::servers::apis::v1::context::stats::resources::Stats;
 use torrust_tracker_primitives::peer::fixture::PeerBuilder;
 use torrust_tracker_test_helpers::configuration;
-use tracing::level_filters::LevelFilter;
 
 use crate::common::logging::{self};
 use crate::servers::api::connection_info::{connection_with_invalid_token, connection_with_no_token};
@@ -14,6 +13,8 @@ use crate::servers::api::Started;
 
 #[tokio::test]
 async fn should_allow_getting_tracker_statistics() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     env.add_torrent_peer(
@@ -60,7 +61,7 @@ async fn should_allow_getting_tracker_statistics() {
 
 #[tokio::test]
 async fn should_not_allow_getting_tracker_statistics_for_unauthenticated_users() {
-    logging::setup(LevelFilter::ERROR);
+    logging::setup();
 
     let env = Started::new(&configuration::ephemeral().into()).await;
 

tests/servers/api/v1/contract/context/torrent.rs

@@ -5,7 +5,6 @@ use torrust_tracker::servers::apis::v1::context::torrent::resources::peer::Peer;
 use torrust_tracker::servers::apis::v1::context::torrent::resources::torrent::{self, Torrent};
 use torrust_tracker_primitives::peer::fixture::PeerBuilder;
 use torrust_tracker_test_helpers::configuration;
-use tracing::level_filters::LevelFilter;
 
 use crate::common::http::{Query, QueryParam};
 use crate::common::logging::{self};
@@ -22,6 +21,8 @@ use crate::servers::api::Started;
 
 #[tokio::test]
 async fn should_allow_getting_all_torrents() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     let info_hash = InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap();
@@ -46,6 +47,8 @@ async fn should_allow_getting_all_torrents() {
 
 #[tokio::test]
 async fn should_allow_limiting_the_torrents_in_the_result() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     // torrents are ordered alphabetically by infohashes
@@ -75,6 +78,8 @@ async fn should_allow_limiting_the_torrents_in_the_result() {
 
 #[tokio::test]
 async fn should_allow_the_torrents_result_pagination() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     // torrents are ordered alphabetically by infohashes
@@ -104,6 +109,8 @@ async fn should_allow_the_torrents_result_pagination() {
 
 #[tokio::test]
 async fn should_allow_getting_a_list_of_torrents_providing_infohashes() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     let info_hash_1 = InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap(); // DevSkim: ignore DS173237
@@ -146,6 +153,8 @@ async fn should_allow_getting_a_list_of_torrents_providing_infohashes() {
 
 #[tokio::test]
 async fn should_fail_getting_torrents_when_the_offset_query_parameter_cannot_be_parsed() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     let invalid_offsets = [" ", "-1", "1.1", "INVALID OFFSET"];
@@ -163,6 +172,8 @@ async fn should_fail_getting_torrents_when_the_offset_query_parameter_cannot_be_
 
 #[tokio::test]
 async fn should_fail_getting_torrents_when_the_limit_query_parameter_cannot_be_parsed() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     let invalid_limits = [" ", "-1", "1.1", "INVALID LIMIT"];
@@ -180,6 +191,8 @@ async fn should_fail_getting_torrents_when_the_limit_query_parameter_cannot_be_p
 
 #[tokio::test]
 async fn should_fail_getting_torrents_when_the_info_hash_parameter_is_invalid() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     let invalid_info_hashes = [" ", "-1", "1.1", "INVALID INFO_HASH"];
@@ -201,7 +214,7 @@ async fn should_fail_getting_torrents_when_the_info_hash_parameter_is_invalid()
 
 #[tokio::test]
 async fn should_not_allow_getting_torrents_for_unauthenticated_users() {
-    logging::setup(LevelFilter::ERROR);
+    logging::setup();
 
     let env = Started::new(&configuration::ephemeral().into()).await;
 
@@ -222,6 +235,8 @@ async fn should_not_allow_getting_torrents_for_unauthenticated_users() {
 
 #[tokio::test]
 async fn should_allow_getting_a_torrent_info() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     let info_hash = InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap();
@@ -251,6 +266,8 @@ async fn should_allow_getting_a_torrent_info() {
 
 #[tokio::test]
 async fn should_fail_while_getting_a_torrent_info_when_the_torrent_does_not_exist() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     let info_hash = InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap();
@@ -266,6 +283,8 @@ async fn should_fail_while_getting_a_torrent_info_when_the_torrent_does_not_exis
 
 #[tokio::test]
 async fn should_fail_getting_a_torrent_info_when_the_provided_infohash_is_invalid() {
+    logging::setup();
+
     let env = Started::new(&configuration::ephemeral().into()).await;
 
     for invalid_infohash in &invalid_infohashes_returning_bad_request() {
@@ -285,7 +304,7 @@ async fn should_fail_getting_a_torrent_info_when_the_provided_infohash_is_invali
 
 #[tokio::test]
 async fn should_not_allow_getting_a_torrent_info_for_unauthenticated_users() {
-    logging::setup(LevelFilter::ERROR);
+    logging::setup();
 
     let env = Started::new(&configuration::ephemeral().into()).await;