Skip to content

Conversation

@josecelano
Copy link
Member

@josecelano josecelano commented Jun 2, 2025

Add a new metric to count UDP wrong connection ID errors per client's software.

Subtasks

  • Wrapper for aquatic parse error. It's not sendable.
  • Add the error to the Event::UdpError event.
  • Move logic to increase the number of wrong connection IDs per IP to the event listener.
  • Add a new metric to increment the counter per client's software/version.
    • This requires adding the peer info (if available)

…t sendable

The error will be included in the UdpError event ans sent via tokio
channel.
@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 17 lines in your changes missing coverage. Please review.

Project coverage is 83.38%. Comparing base (059d2b6) to head (21bea5b).

Files with missing lines Patch % Lines
packages/udp-tracker-server/src/event.rs 35.29% 11 Missing ⚠️
packages/udp-tracker-server/src/error.rs 80.95% 4 Missing ⚠️
packages/udp-tracker-server/src/handlers/error.rs 92.30% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1550      +/-   ##
===========================================
+ Coverage    83.35%   83.38%   +0.02%     
===========================================
  Files          275      276       +1     
  Lines        19601    19716     +115     
  Branches     19601    19716     +115     
===========================================
+ Hits         16339    16440     +101     
- Misses        2962     2975      +13     
- Partials       300      301       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Not exposing the original complex error type becuase:

- It's too complex.
- It forces all errors to be "Sent", "PartialEq".
- It would expose a lot of internals.
@josecelano josecelano requested a review from da2ce7 June 2, 2025 16:08
@josecelano josecelano changed the title Add metrics for UDP client software when the client makes a wrong request. Add metric for UDP client software when the client makes a wrong request. Jun 2, 2025
@josecelano
Copy link
Member Author

I decided to split this PR into two:

@josecelano josecelano closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant