Skip to content

Conversation

@josecelano
Copy link
Member

Fix bug. The ban service should work even when statistics are disabled. There was only one event listener in the UDP tracker server package to update stats and update ban service data (increase banning counters). However, the listener was disabled when stats were not needed.

The ban service should be always be enabled (or at least enable/disable it independently from stats).

The problem has been fixed by creating an independent event listener for the banning service that is always enabled.

In the future, we could add a config option to enable/disable it.

@josecelano josecelano force-pushed the 1565-overhaul-stats-decouple-stats-and-ban-service-event-listeners-in-udp-tracker-server-package branch from caa60e6 to 9e45ad7 Compare June 9, 2025 16:35
@josecelano josecelano force-pushed the 1565-overhaul-stats-decouple-stats-and-ban-service-event-listeners-in-udp-tracker-server-package branch from 9e45ad7 to d81e59e Compare June 9, 2025 16:35
@josecelano josecelano requested a review from da2ce7 June 9, 2025 16:36
@josecelano
Copy link
Member Author

ACK d81e59e

@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 82.43243% with 13 lines in your changes missing coverage. Please review.

Project coverage is 83.93%. Comparing base (d949e48) to head (d81e59e).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...s/udp-tracker-server/src/banning/event/listener.rs 52.00% 11 Missing and 1 partial ⚠️
packages/udp-tracker-server/src/environment.rs 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1567      +/-   ##
===========================================
- Coverage    83.98%   83.93%   -0.05%     
===========================================
  Files          282      284       +2     
  Lines        20298    20305       +7     
  Branches     20298    20305       +7     
===========================================
- Hits         17047    17044       -3     
- Misses        2954     2961       +7     
- Partials       297      300       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@josecelano josecelano self-assigned this Jun 9, 2025
@josecelano josecelano added Code Cleanup / Refactoring Tidying and Making Neat - Developer - Torrust Improvement Experience Bug Incorrect Behavior labels Jun 9, 2025
@josecelano josecelano merged commit 04de1df into torrust:develop Jun 9, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

- Developer - Torrust Improvement Experience Bug Incorrect Behavior Code Cleanup / Refactoring Tidying and Making Neat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overhaul stats: Decouple stats and ban service event listeners in udp-tracker-server package

1 participant