-
Notifications
You must be signed in to change notification settings - Fork 49
Overhaul stats: Fix Prometheus export to include only one HELP and TYPE lines per metric #1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
josecelano
merged 1 commit into
torrust:develop
from
josecelano:1569-overhaul-stats-fix-prometheus-export-to-include-only-one-help-and-type-lines-per-metric
Jun 10, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…YPE header per metric
Current format:
```
# HELP udp_tracker_server_connection_id_errors_total Total number of requests with connection ID errors
# TYPE udp_tracker_server_connection_id_errors_total counter
udp_tracker_server_connection_id_errors_total{client_software_name="Other (BC)",client_software_version="0087"} 4
# HELP udp_tracker_server_connection_id_errors_total Total number of requests with connection ID errors
# TYPE udp_tracker_server_connection_id_errors_total counter
udp_tracker_server_connection_id_errors_total{client_software_name="Other (FD66)",client_software_version=""} 1
# HELP udp_tracker_server_connection_id_errors_total Total number of requests with connection ID errors
# TYPE udp_tracker_server_connection_id_errors_total counter
udp_tracker_server_connection_id_errors_total{client_software_name="Other (SP)",client_software_version="3605"} 631
# HELP udp_tracker_server_connection_id_errors_total Total number of requests with connection ID errors
# TYPE udp_tracker_server_connection_id_errors_total counter
udp_tracker_server_connection_id_errors_total{client_software_name="Other (TIX0325)",client_software_version=""} 14
# HELP udp_tracker_server_connection_id_errors_total Total number of requests with connection ID errors
# TYPE udp_tracker_server_connection_id_errors_total counter
udp_tracker_server_connection_id_errors_total{client_software_name="Other (BC)",client_software_version="0202"} 6754
# HELP udp_tracker_server_connection_id_errors_total Total number of requests with connection ID errors
# TYPE udp_tracker_server_connection_id_errors_total counter
udp_tracker_server_connection_id_errors_total{client_software_name="Other (XF)",client_software_version="9400"} 1
# HELP udp_tracker_server_connection_id_errors_total Total number of requests with connection ID errors
# TYPE udp_tracker_server_connection_id_errors_total counter
udp_tracker_server_connection_id_errors_total{client_software_name="Other (BC)",client_software_version="0090"} 7
# HELP udp_tracker_server_connection_id_errors_total Total number of requests with connection ID errors
# TYPE udp_tracker_server_connection_id_errors_total counter
udp_tracker_server_connection_id_errors_total{client_software_name="Transmission",client_software_version="2.32"} 1
# HELP udp_tracker_server_connection_id_errors_total Total number of requests with connection ID errors
# TYPE udp_tracker_server_connection_id_errors_total counter
udp_tracker_server_connection_id_errors_total{client_software_name="Other (61-b39e)",client_software_version=""} 1
```
Expected format:
```
# HELP udp_tracker_server_connection_id_errors_total Total number of requests with connection ID errors
# TYPE udp_tracker_server_connection_id_errors_total counter
udp_tracker_server_connection_id_errors_total{client_software_name="Other (BC)",client_software_version="0087"} 4
udp_tracker_server_connection_id_errors_total{client_software_name="Other (FD66)",client_software_version=""} 1
udp_tracker_server_connection_id_errors_total{client_software_name="Other (SP)",client_software_version="3605"} 631
udp_tracker_server_connection_id_errors_total{client_software_name="Other (TIX0325)",client_software_version=""} 14
udp_tracker_server_connection_id_errors_total{client_software_name="Other (BC)",client_software_version="0202"} 6754
udp_tracker_server_connection_id_errors_total{client_software_name="Other (XF)",client_software_version="9400"} 1
udp_tracker_server_connection_id_errors_total{client_software_name="Other (BC)",client_software_version="0090"} 7
udp_tracker_server_connection_id_errors_total{client_software_name="Transmission",client_software_version="2.32"} 1
udp_tracker_server_connection_id_errors_total{client_software_name="Other (61-b39e)",client_software_version=""} 1
```
A line break after each metric has also been added to improve readability.
b04675e to
02433cb
Compare
Member
Author
|
ACK 02433cb |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1574 +/- ##
===========================================
- Coverage 83.88% 83.85% -0.03%
===========================================
Files 284 284
Lines 20333 20318 -15
Branches 20333 20318 -15
===========================================
- Hits 17056 17038 -18
- Misses 2976 2979 +3
Partials 301 301 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Prometheus export to include only one
HELPandTYPElines per metric.Current format:
Expected format:
A line break has also been added after each metric to improve readability.