fix: ** (power) does not get translated to POWER in MSSQL#34
Merged
waketzheng merged 6 commits intotortoise:mainfrom Jun 15, 2025
Merged
fix: ** (power) does not get translated to POWER in MSSQL#34waketzheng merged 6 commits intotortoise:mainfrom
** (power) does not get translated to POWER in MSSQL#34waketzheng merged 6 commits intotortoise:mainfrom
Conversation
henadzit
reviewed
Jun 14, 2025
pypika_tortoise/terms.py
Outdated
|
|
||
| def get_function_sql(self, ctx: SqlContext) -> str: | ||
| if ctx.dialect == Dialects.MSSQL: | ||
| self.name = "POWER" |
Contributor
There was a problem hiding this comment.
It's a hell of a side effect when get_function_sql changes the object state. You don't expect a getter to change the state.
I think we can make name a function accepting SqlContext in Function, and then override it in Pow.
Contributor
Author
There was a problem hiding this comment.
I think we can make name a function accepting SqlContext in Function, and then override it in Pow.
It seems hard to do that, so I use a new func get_dialect_special_name
henadzit
approved these changes
Jun 15, 2025
Contributor
henadzit
left a comment
henadzit
left a comment
There was a problem hiding this comment.
LGTM! Thanks for addressing the feedback!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15