Skip to content

Conversation

@henadzit
Copy link
Contributor

@henadzit henadzit commented Jan 2, 2025

Description

This PR adds the following Codspeed benchmarks:

  • test_bulk_create_few_fields and test_bulk_create_many_fields that benchmark bulk_create
  • test_filter_many_filters that benchmarks filtering when multiple filters are used

Motivation and Context

I am working on a performance improvements, there benchmarks are going to provide a baseline.

How Has This Been Tested?

make ci

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@henadzit henadzit requested review from abondar and waketzheng January 2, 2025 15:40
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 2, 2025

CodSpeed Performance Report

Merging #1834 will not alter performance

Comparing henadzit:feat/more-benchmarks (769bc90) with develop (be5bbc1)

Summary

✅ 5 untouched benchmarks
🆕 3 new benchmarks

Benchmarks breakdown

Benchmark develop henadzit:feat/more-benchmarks Change
🆕 test_bulk_create_few_fields N/A 3 ms N/A
🆕 test_bulk_create_many_fields N/A 17.6 ms N/A
🆕 test_filter_many_filters N/A 3.5 ms N/A

@henadzit henadzit force-pushed the feat/more-benchmarks branch from 90265d7 to 64be163 Compare January 2, 2025 15:46
@coveralls
Copy link

coveralls commented Jan 2, 2025

Pull Request Test Coverage Report for Build 12595235585

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.145%

Totals Coverage Status
Change from base Build 12595126204: 0.0%
Covered Lines: 6460
Relevant Lines: 7048

💛 - Coveralls

@henadzit henadzit force-pushed the feat/more-benchmarks branch from 64be163 to 769bc90 Compare January 3, 2025 08:57
@henadzit henadzit merged commit 7afc90e into tortoise:develop Jan 3, 2025
10 checks passed
@henadzit
Copy link
Contributor Author

henadzit commented Jan 3, 2025

@waketzheng thank you for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants