-
-
Notifications
You must be signed in to change notification settings - Fork 445
Use pypika's SqlContext to improve performance #1837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #1837 will improve performances by 23.49%Comparing Summary
Benchmarks breakdown
|
abcb490 to
95565ad
Compare
Pull Request Test Coverage Report for Build 12713770244Details
💛 - Coveralls |
|
@abondar any chance you can have a look at this? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, it looks much better that way, then implicit kwargs
I'll try to not miss when you update PR with actual lib version to reapprove, but if I don't - don't hesitate to tag me please. I am still a little bit in new year vibe (:
f81336d to
d487ebe
Compare
|
@abondar happy new year! I've updated pypika-tortoise, so it's ready for review again. |
Description
SqlContextintroduced in pypika-tortoise 0.5.0Motivation and Context
This PR improves the performance of SQL generation by pypika (see the Codspeed comment for more details), hence improving over query performance:
test_get_many_fieldsbenchmarktest_filter_many_filtersbenchmarktest_filter_few_fieldsHow Has This Been Tested?
make ciChecklist: