feat: drop support for Python3.8 #1848
Conversation
CodSpeed Performance ReportMerging #1848 will not alter performanceComparing Summary
|
Pull Request Test Coverage Report for Build 12879310652Details
💛 - Coveralls |
henadzit
left a comment
henadzit
left a comment
There was a problem hiding this comment.
Great job on replacing List, Dict, etc.!
| meta.fields_db_projection = fields_db_projection | ||
| meta._filters = filters | ||
| meta.fk_fields = fk_fields | ||
| meta.backward_fk_fields = set() |
There was a problem hiding this comment.
Why are backward_fk_fields, default_connection and other fields are removed from here?
There was a problem hiding this comment.
Because there are defined in MetaInfo.__init__:
tortoise-orm/tortoise/models.py
Line 240 in 71624e7
tortoise/models.py
Outdated
| class ModelMeta(type): | ||
| __slots__ = () | ||
| # Searching for Field attributes in the class hierarchy | ||
| def _search_for_field_attributes(base: Type, attrs: dict) -> None: |
There was a problem hiding this comment.
I think it should be a static method as parse_custom_pk and dispatch_fields, I don't see a reason why we would want to keep it as a function.
There was a problem hiding this comment.
Moved it into ModelMeta as a classmethod, because it's a recursion function that can not be set as staticmethod.
3 participants
Description
Python3.8 already EOL: https://devguide.python.org/versions/
Motivation and Context
Changes:
typing.List/Tuple/Set/Dict-->list/tuple/set/dicttyping.Callable/Coroutine/Iterable/...-->collections.abc.Callable/Coroutine/Iterable/...functools.lru_cache(maxsize=None)-->functools.cachesuper(xxx, self)->super()tortoise.models.ModelMetato fix codacy issue (python -m mccabe --min 15 tortoise/models.py)How Has This Been Tested?
make ci
Checklist: