Skip to content

Conversation

@waketzheng
Copy link
Contributor

Description

Since Python3.9 typing.Type can be replaced by builtins.type:
https://docs.python.org/3.9/library/typing.html#typing.Type

Motivation and Context

How Has This Been Tested?

make ci

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 24, 2025

CodSpeed Performance Report

Merging #1864 will not alter performance

Comparing waketzheng:replace-Type (8d1f7d6) with develop (3a5e836)

Summary

✅ 8 untouched benchmarks

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12950411609

Details

  • 96 of 101 (95.05%) changed or added relevant lines in 26 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 89.421%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/exceptions.py 4 5 80.0%
tortoise/fields/base.py 6 8 75.0%
tortoise/fields/relational.py 2 4 50.0%
Totals Coverage Status
Change from base Build 12927974311: -0.002%
Covered Lines: 6492
Relevant Lines: 7077

💛 - Coveralls

@waketzheng waketzheng requested review from abondar and henadzit and removed request for abondar January 24, 2025 15:51
@waketzheng waketzheng merged commit c892d34 into tortoise:develop Feb 5, 2025
9 checks passed
@waketzheng waketzheng deleted the replace-Type branch February 5, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants